Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/add tutorial #348

Merged
merged 18 commits into from Oct 2, 2019
Merged

Docs/add tutorial #348

merged 18 commits into from Oct 2, 2019

Conversation

vyasr
Copy link
Collaborator

@vyasr vyasr commented Jul 22, 2019

Description

Adds more documentation to the package, starting with an introduction to what freud is, a quick start guide, and a more detailed tutorial. This PR should not be merged until all of the neighbor finding refactoring is complete, since we need to verify that all the APIs, etc are correct.

Motivation and Context

Our current documentation only includes API information, but has no guidance for users on how to start out using freud. This PR addresses that need.

Also resolves #274 as much as we can; I suggest fleshing that section out as we receive questions on specific other data formats people want to read into freud.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the Changelog.

@vyasr vyasr mentioned this pull request Jul 22, 2019
10 tasks
@vyasr vyasr requested review from bdice and jinsoo960 July 22, 2019 01:54
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr Really nice work - I think this gives us something concrete and it touches on a lot of important use cases. I have a first round of comments below.

doc/source/gettingstarted.rst Outdated Show resolved Hide resolved
doc/source/gettingstarted.rst Outdated Show resolved Hide resolved
doc/source/gettingstarted.rst Outdated Show resolved Hide resolved
doc/source/gettingstarted.rst Outdated Show resolved Hide resolved
doc/source/gettingstarted.rst Outdated Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Outdated Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Outdated Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Outdated Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Outdated Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (next@cb6cc69). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #348   +/-   ##
=======================================
  Coverage        ?   90.43%           
=======================================
  Files           ?       17           
  Lines           ?     2071           
  Branches        ?       19           
=======================================
  Hits            ?     1873           
  Misses          ?      188           
  Partials        ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6cc69...a89e839. Read the comment docs.

@bdice bdice removed the request for review from jinsoo960 August 15, 2019 14:27
@bdice bdice assigned vyasr and bdice Aug 15, 2019
@bdice bdice added documentation enhancement New feature or request labels Aug 15, 2019
@bdice bdice added this to the v2.0 milestone Aug 15, 2019
@vyasr vyasr mentioned this pull request Aug 22, 2019
9 tasks
@vyasr
Copy link
Collaborator Author

vyasr commented Aug 23, 2019

Need to add docs for #395, specifically how the query arguments work.

@vyasr vyasr mentioned this pull request Sep 9, 2019
10 tasks
@vyasr vyasr mentioned this pull request Sep 27, 2019
9 tasks
@vyasr vyasr changed the base branch from next to refactor/update_locality_matchenv_apis October 1, 2019 18:25
@vyasr vyasr changed the base branch from refactor/update_locality_matchenv_apis to next October 1, 2019 18:46
@vyasr vyasr marked this pull request as ready for review October 2, 2019 12:51
@vyasr vyasr requested a review from a team as a code owner October 2, 2019 12:51
@vyasr vyasr requested a review from bdice October 2, 2019 12:51
'numpy': ('https://docs.scipy.org/doc/numpy', None),
'matplotlib': ('https://matplotlib.org', None),
'hoomd': ('https://hoomd-blue.readthedocs.io/en/stable/', None),
}

autodoc_mock_import = ["numpy"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed anymore? We have intersphinx mapping, so I don't think we have to fake it with mock imports. Not sure.

doc/source/datainputs.rst Show resolved Hide resolved
doc/source/datainputs.rst Show resolved Hide resolved
doc/source/datainputs.rst Show resolved Hide resolved
doc/source/datainputs.rst Show resolved Hide resolved
doc/source/tutorial/computeclass.rst Show resolved Hide resolved
doc/source/tutorial/computeclass.rst Show resolved Hide resolved
doc/source/tutorial/computeclass.rst Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Show resolved Hide resolved
doc/source/tutorial/neighborfinding.rst Show resolved Hide resolved
@vyasr vyasr merged commit 0e0e3b8 into next Oct 2, 2019
@vyasr vyasr deleted the docs/add_tutorial branch October 2, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants