New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/add tutorial #348
Docs/add tutorial #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasr Really nice work - I think this gives us something concrete and it touches on a lot of important use cases. I have a first round of comments below.
af5c8d8
to
717cad3
Compare
Codecov Report
@@ Coverage Diff @@
## next #348 +/- ##
=======================================
Coverage ? 90.43%
=======================================
Files ? 17
Lines ? 2071
Branches ? 19
=======================================
Hits ? 1873
Misses ? 188
Partials ? 10 Continue to review full report at Codecov.
|
717cad3
to
5746017
Compare
Need to add docs for #395, specifically how the query arguments work. |
5746017
to
8fde631
Compare
'numpy': ('https://docs.scipy.org/doc/numpy', None), | ||
'matplotlib': ('https://matplotlib.org', None), | ||
'hoomd': ('https://hoomd-blue.readthedocs.io/en/stable/', None), | ||
} | ||
|
||
autodoc_mock_import = ["numpy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed anymore? We have intersphinx mapping, so I don't think we have to fake it with mock imports. Not sure.
Description
Adds more documentation to the package, starting with an introduction to what freud is, a quick start guide, and a more detailed tutorial. This PR should not be merged until all of the neighbor finding refactoring is complete, since we need to verify that all the APIs, etc are correct.
Motivation and Context
Our current documentation only includes API information, but has no guidance for users on how to start out using freud. This PR addresses that need.
Also resolves #274 as much as we can; I suggest fleshing that section out as we receive questions on specific other data formats people want to read into freud.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: