Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recent versions of pytest #37

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Support recent versions of pytest #37

merged 4 commits into from
Sep 3, 2019

Conversation

joaander
Copy link
Member

Description

  • Simplify test code using pytest fixtures and parameterize features.
  • Support pathlib paths

Motivation and Context

Pytest removed yield based tests, this prevented new versions of pytest from running all of gsd's tests. Going forward, pytest's fixture and parameterize features greatly simplify the test code, making it easier to read and write - at the expense of requiring pytest for testing and no longer supporting nose.

Specifically, pytest >= 3.9 is needed for tmp_path support.

How Has This Been Tested?

CI tests pass with pytest 5.

Change log

* pytest >= 3.9.0 is required to run unit tests
* ``gsd.fl.open`` and ``gsd.hoomd.open`` accept objects implementing ``os.PathLike``

Checklist:

@joaander joaander requested review from a team August 21, 2019 11:46
@ghost ghost requested review from lyrivera and bdice and removed request for lyrivera and a team August 21, 2019 11:46
@joaander joaander requested a review from lyrivera August 21, 2019 11:47
@joaander joaander changed the title Support recent version of pytest Support recent versions of pytest Aug 21, 2019
@joaander joaander added this to the v1.9.0 milestone Aug 21, 2019
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bdice bdice mentioned this pull request Aug 21, 2019
6 tasks
Copy link
Contributor

@lyrivera lyrivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with CI configurations yet, but the actual tests look good.

@joaander joaander merged commit 4369e03 into master Sep 3, 2019
@joaander joaander deleted the pytest5 branch September 3, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants