Add HPMC pair union benchmark. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
tcmoore3,
b-butler and
syjlee
and removed request for
a team
b-butler
approved these changes
Mar 4, 2024
Comment on lines
+85
to
+87
| positions.extend([(x, 0, 0) for x in points]) | ||
| positions.extend([(0, x, 0) for x in points]) | ||
| positions.extend([(0, 0, x) for x in points]) |
There was a problem hiding this comment.
Wouldn't this result in overlaps if grid is chosen poorly? Also. this doesn't form a grid as points are only placed on the axes lines. That isn't necessarily a problem, just makes the argument name grid seem odd.
There was a problem hiding this comment.
Yes, it should be named "spacing" or something like that. This benchmark attempts to prevent overlaps by keeping the overall particles the same size and placing overlapping constituents.
It is not a very realistic placement, but I used it to get some idea of what union size was the minimum needed for leaf_capacity=4 to be faster than leaf_capacity=0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Benchmark the HPMC union potential.
Motivation and context
Check the performance of new code paths added in glotzerlab/hoomd-blue#1725
How has this been tested?
The benchmark runs locally.
Checklist:
CONTRIBUTORS.md) in the pull request source branch.