You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@joaander out of scope for this PR, and maybe just too late altogether now that #894 has been merged, but something I just thought of: perhaps it would be a good idea to typedef uint64_t TimestepType? I actually don't think it would be horribly difficult, a find hoomd -regex '.*\.(?:h|cc|cu|cuh)' -exec sed -i 's/uint64_t timestep/TimestepType timestep/g' \; should get you most of the way there. More than future proofing (I can't imagine the time step type changing again anytime soon), this would make the code more readable and easier to avoid errors from future devs.
@joaander out of scope for this PR, and maybe just too late altogether now that #894 has been merged, but something I just thought of: perhaps it would be a good idea to
typedef uint64_t TimestepType
? I actually don't think it would be horribly difficult, afind hoomd -regex '.*\.(?:h|cc|cu|cuh)' -exec sed -i 's/uint64_t timestep/TimestepType timestep/g' \;
should get you most of the way there. More than future proofing (I can't imagine the time step type changing again anytime soon), this would make the code more readable and easier to avoid errors from future devs.Originally posted by @vyasr in #842 (comment)
The text was updated successfully, but these errors were encountered: