Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a typedef for timestep time. #978

Closed
vyasr opened this issue Apr 15, 2021 · 3 comments
Closed

Create a typedef for timestep time. #978

vyasr opened this issue Apr 15, 2021 · 3 comments
Labels
stale There has been no activity on this for some time.

Comments

@vyasr
Copy link
Contributor

vyasr commented Apr 15, 2021

@joaander out of scope for this PR, and maybe just too late altogether now that #894 has been merged, but something I just thought of: perhaps it would be a good idea to typedef uint64_t TimestepType? I actually don't think it would be horribly difficult, a find hoomd -regex '.*\.(?:h|cc|cu|cuh)' -exec sed -i 's/uint64_t timestep/TimestepType timestep/g' \; should get you most of the way there. More than future proofing (I can't imagine the time step type changing again anytime soon), this would make the code more readable and easier to avoid errors from future devs.

Originally posted by @vyasr in #842 (comment)

@bdice
Copy link
Member

bdice commented Apr 20, 2021

Or possibly using TimestepType = uint64_t;. See this StackOverflow post for some details.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale There has been no activity on this for some time. label Mar 22, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This issue has been automatically closed because it has not had recent activity.

@github-actions github-actions bot closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale There has been no activity on this for some time.
Projects
None yet
Development

No branches or pull requests

2 participants