Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virial pressure documentation. #1548

Merged
merged 1 commit into from May 12, 2023
Merged

Fix virial pressure documentation. #1548

merged 1 commit into from May 12, 2023

Conversation

joaander
Copy link
Member

@joaander joaander commented May 10, 2023 •
edited

Description

  • Remove extra factor of 1/D from W_isotropic. This factor is present in the previous equation: P = ... W/D
  • Move the pressure tensor equation out of the definition list.

Motivation and context

Correctly document HOOMD-blue's computations.

How has this been tested?

I rendered the documentation locally.

Change log

Fixed:

* Correct equations in virial pressure documentation.

Checklist:

@joaander joaander requested review from a team as code owners May 10, 2023 15:10
@joaander joaander requested review from b-butler and cbkerr and removed request for a team May 10, 2023 15:10
@joaander joaander added the validate Execute long running validation tests on pull requests label May 10, 2023
@joaander joaander merged commit 55bcc52 into trunk-major May 12, 2023
56 of 68 checks passed
@joaander joaander deleted the fix-virial-pressure-docs branch May 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-butler b-butler b-butler approved these changes

@cbkerr cbkerr Awaiting requested review from cbkerr cbkerr is a code owner automatically assigned from glotzerlab/hoomd-reviewers

Assignees
No one assigned
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaander @b-butler