Fix compilation error with LLVM 16. #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
requested review from
b-butler and
janbridley
and removed request for
a team
joaander
added
validate
b-butler
approved these changes
Jun 5, 2023
janbridley
approved these changes
Jun 5, 2023
|
#1569 documents the future testing work to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compile errors with LLVM 16.
Motivation and context
Allow users to compile HOOMD-blue against LLVM 16.
Resolves #1540
How has this been tested?
Tested locally with a LLVM 16 install provided by homebrew.
CI tests do not include LLVM16. Ubuntu 22.04 does not have a package: https://packages.ubuntu.com/search?keywords=clang-16&searchon=names&suite=all§ion=all
Will add LLVM 16 test next year with Ubuntu 24.04.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.