Fix release workflow. #1572
Merged
Fix release workflow. #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
force-pushed
the
fix-release-workflow
branch
from
035ba76
to
33225f7
Compare
joaander
force-pushed
the
fix-release-workflow
branch
from
33225f7
to
cd8cc9c
Compare
joaander
added
the
validate
|
The workflow runs with expected outputs: https://github.com/glotzerlab/hoomd-blue/actions/runs/5201213251/jobs/9381031912?pr=1572 |
b-butler
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove "v" prefix from version name.
Motivation and context
v1.2.3is not a semantic version (https://semver.org/#is-v123-a-semantic-version).We will continue to use the
vprefix on git tags, but release notes, e-mails, tarballs, etc.. should all refer to the correct semantic verison.How has this been tested?
Will inspect the pull request checks.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.