feat: Add __len__ to Burst writer #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
tommy-waltmann and
shihkual
and removed request for
a team
tommy-waltmann
requested changes
Jun 15, 2023
hoomd/md/pytest/test_burst_writer.py
Outdated
Comment on lines
143
to
145
| assert (burst_writer) == 3 | ||
| burst_writer.dump() | ||
| assert (burst_writer) == 0 |
There was a problem hiding this comment.
Are these supposed to say len(burst_writer) and not (burst_writer)?
b-butler
commented
Jun 15, 2023
tommy-waltmann
approved these changes
Jun 16, 2023
joaander
added
the
validate
shihkual
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
__len__method toBurst.Motivation and context
This is useful for custom actions which use
Burst.How has this been tested?
Added a new test.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.