added default_gamma and default_gamma_r arguments to rattle methods
#1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melodyyzh
requested review from
tommy-waltmann and
shihkual
and removed request for
a team
melodyyzh
added
the
validate
tommy-waltmann
approved these changes
Aug 2, 2023
joaander
approved these changes
Aug 3, 2023
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default_gammaanddefault_gamma_rarguments do not exist in the following constructors:hoomd.md.methods.rattle.Brownianhoomd.md.methods.rattle.Langevinhoomd.md.methods.rattle.OverdampedViscousThis PR added these arguments to the corresponding classes and doc strings.
Motivation and context
Resolves #1589
How has this been tested?
Appended the test case before
test_default_gammafunction intest_methods.pyChange log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.