Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite passes on the ROCm platform. #1607

Merged
merged 5 commits into from Aug 17, 2023

Conversation

joaander
Copy link
Member

@joaander joaander commented Aug 11, 2023

Description

Changes needed so the test suite passes on OLCF Frontier.

  1. Fix the test_clusters.py seg fault.
  2. Mark test_pivot_moves as xfail on ROCm platform: hpmc.update.Clusters produces incorrect results on the ROCm platform. #1605.
  3. Skip test_force_energy_relationship[GPU-Tersoff] as xfail on ROCm platform: test_force_energy_relationship[GPU-Tersoff] fails on ROCm backend #1606.

The tmp_path change is necessary to allow pytest to run in user's home directories on Frontier.

Motivation and context

Builds on Frontier should pass pytest hoomd. The root causes of the problems in #1605 and #1606 are not apparent at this time. I am using pytest.xfail to mark the failing test and pytest.skip to skip the test that causes a seg fault.

Resolves #1479

How has this been tested?

I built HOOMD and ran pytest on OLCF Frontier.

Change log

Fixed:

* Access valid GPU memory in `hoomd.hpmc.update.Clusters`.
* Test suite passes on the ROCm GPU platform.

Checklist:

@joaander joaander requested review from a team as code owners August 11, 2023 17:41
@joaander joaander requested review from tcmoore3 and bdice and removed request for a team August 11, 2023 17:41
@tcmoore3
Copy link
Member

pre-commit.ci autofix

Copy link
Member

@tcmoore3 tcmoore3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaander joaander added the validate Execute long running validation tests on pull requests label Aug 14, 2023
@joaander joaander merged commit e36fdf0 into trunk-patch Aug 17, 2023
72 of 73 checks passed
@joaander joaander deleted the fix-test-clusters-seg-fault branch August 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in HPMC unit tests on Crusher.
2 participants