Test suite passes on the ROCm platform. #1607
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes needed so the test suite passes on OLCF Frontier.
test_clusters.py
seg fault.test_pivot_moves
as xfail on ROCm platform:hpmc.update.Clusters
produces incorrect results on the ROCm platform. #1605.test_force_energy_relationship[GPU-Tersoff]
as xfail on ROCm platform:test_force_energy_relationship[GPU-Tersoff]
fails on ROCm backend #1606.The
tmp_path
change is necessary to allowpytest
to run in user's home directories on Frontier.Motivation and context
Builds on Frontier should pass
pytest hoomd
. The root causes of the problems in #1605 and #1606 are not apparent at this time. I am usingpytest.xfail
to mark the failing test andpytest.skip
to skip the test that causes a seg fault.Resolves #1479
How has this been tested?
I built HOOMD and ran
pytest
on OLCF Frontier.Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.