Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "How to prevent particles from moving." #1611

Merged
merged 4 commits into from Aug 29, 2023

Conversation

joaander
Copy link
Member

Description

Add a how to guide that explains how to prevent particles from moving.

Motivation and context

This is a commonly asked question on the mailing list.

Resolves #1516.

How has this been tested?

I built and viewed the generated documentation.

Change log

Added:

* How-to documentation page: "How to prevent particles from moving".

Checklist:

@joaander joaander requested review from a team as code owners August 28, 2023 18:55
@joaander joaander requested review from tommy-waltmann and cbkerr and removed request for a team August 28, 2023 18:55
@joaander joaander added the validate Execute long running validation tests on pull requests label Aug 28, 2023
Copy link
Contributor

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good. I think using the terms "stationary" and "mobile" would make the wording clearer.

sphinx-doc/howto/prevent-particles-from-moving.rst Outdated Show resolved Hide resolved
sphinx-doc/howto/prevent-particles-from-moving.rst Outdated Show resolved Hide resolved
sphinx-doc/howto/prevent-particles-from-moving.rst Outdated Show resolved Hide resolved
sphinx-doc/howto/prevent-particles-from-moving.rst Outdated Show resolved Hide resolved
joaander and others added 2 commits August 28, 2023 20:38
Co-authored-by: Tommy Waltmann <53307607+tommy-waltmann@users.noreply.github.com>
Copy link
Contributor

@tommy-waltmann tommy-waltmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small thing.

sphinx-doc/howto/prevent-particles-from-moving.rst Outdated Show resolved Hide resolved
Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I didn't know you could filter by tag!

@joaander joaander merged commit 26fecbc into trunk-minor Aug 29, 2023
39 checks passed
@joaander joaander deleted the howto-prevent-particles-from-moving branch August 29, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants