Fix HPMC pair potential cpp class name in python to enable HPMC pair potentials from external components #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcmoore3
requested review from
joaander,
SchoeniPhlippsn and
rayasare
and removed request for
a team
joaander
added
the
validate
rayasare
approved these changes
May 9, 2024
This fix makes it possible to use external components as HPMC pair potentials.
joaander
force-pushed
the
fix-hpmc-pair-ext-module
branch
from
f4ebcc7
to
497497f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title.
Motivation and context
HOOMD-blue needs to support external components that provide HPMC pair potentials, especially with JIT on its way out.
How has this been tested?
Tested locally. My component builds and runs as expected.
Change log
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.