Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hooks for code style. #117

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Add pre-commit hooks for code style. #117

merged 3 commits into from
Feb 16, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Feb 11, 2021 •
edited

Description

Adds pre-commit checks (run by CircleCI) to enforce code style. Rebase and merge after #116.

Motivation and Context

Adheres to style guides of all other signac repositories.

Checklist:

@bdice bdice requested review from a team as code owners February 11, 2021 21:15
@bdice bdice requested review from mikemhenry and Charlottez112 and removed request for a team February 11, 2021 21:15
@bdice bdice mentioned this pull request Feb 11, 2021
Merged
3 tasks
mikemhenry
mikemhenry approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdice bdice merged commit 1ab8a24 into master Feb 16, 2021
@bdice bdice deleted the pre-commit branch February 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemhenry mikemhenry mikemhenry approved these changes

@Charlottez112 Charlottez112 Awaiting requested review from Charlottez112

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdice @mikemhenry