Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing a grouping feature to organize flow operations #114

Merged
merged 156 commits into from
Feb 21, 2020
Merged

Commits on Jan 16, 2020

  1. Enables the creation and registering of groups.

    * The FlowGroup class was created to represent the group concept and store
    the necessary variables and methods.
    * The classmethod make_group was created which returns a decorator that
    adds a _flow_group label to functions for later registration. In
    addtion, make_group also adds an entry to the new _GROUPS attribute in
    the _FlowProject class.
    * A function _register_groups was added that registers groups by using
    the _GROUPS and _OPERATIONS attributes of the current and parent
    classes.
    * The __init__ method of FlowGroup was changed to automatically register
    groups and add operations at initialization.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    9ff7c74 View commit details
    Browse the repository at this point in the history
  2. Adding function to create group CL arg.

    Adds the group commandline argument to submit, run, and script.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    ebfca36 View commit details
    Browse the repository at this point in the history
  3. First functioning group submit.

    * _main_submit modified to have group path
    * submit_group function added to submit groups
    * changes do not directly update status
    * no checks on if directives work have been made
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b6edd34 View commit details
    Browse the repository at this point in the history
  4. Adding support for groups in run command.

    * changed the way that operation names are gathered for run condition to
    aggregate those chosen from -o and -g options.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    93a35e6 View commit details
    Browse the repository at this point in the history
  5. Adding script support for group option.

    * Raise ValueError if -o/--operation and -g/--group are set together
    * Add logic to include JobGroups as script operations if -o/--operations
    is set.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    48c89f2 View commit details
    Browse the repository at this point in the history
  6. Adding support for command options.

    * Adding an options parameter for groups that appends options to the
    output of FlowGroup's __call__ method. This allows for you to set
    options like --num-passes for a group. These options only currently
    apply during submit and script operations.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d2e7d9a View commit details
    Browse the repository at this point in the history
  7. Adding new methods to FlowGroup.

    * FlowGroups now have a complete and eligible method
    * FlowGroups now have two cmd's run_cmd and exec_cmd
    * FlowGroups.__call__ now takes a flag on cmd mode
    * make_group FlowProject method takes correct args and stores them in
      operation function dict correctly
    * FlowGroups store operations as a dict now
    * _register_groups FlowProject method correctly registers operations
    * Temporary changes made to JobGroup to test FlowGroup function
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    78373d5 View commit details
    Browse the repository at this point in the history
  8. Adding bundling, exec_mode, op group conversion.

    * JobGroups now correctly create unique id.
    * JobOperations are removed as they are redundant.
    * All _main_script and _main_submit always use group pathway now.
    * Exec_mode runs and raises error for groups with more than one job.
    * Bundling works with groups of all kinds.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d542d55 View commit details
    Browse the repository at this point in the history
  9. Changed JobOperation implimentation.

    * Changed functions that gather operations.
    * Changed the structure of JobOperations
    * Add method to FlowGroup to create JobOperations.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    59e9336 View commit details
    Browse the repository at this point in the history
  10. Integration of operation and group execution path.

    * Submit, run , and script all handle groups and operations through -o
    * FlowGroups are always created with knowledge of path now this is
    required because there is not an easy way to find where an object is
    instantiated. The current method uses the stack when using the
    classmethod make_group, and the class attribute _OPERATION_FUNCTIONS
    when creating FlowGroups directly from a FlowOperation.
    * Appropriate errors are raised when undefined behavior might occur.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    28d9b34 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    080abe3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    191e8c6 View commit details
    Browse the repository at this point in the history
  13. Adding requested revisions

    * Changing FlowGroups compatible method
    * Moving submit and JobOperation back to original location
    * Added a groups property to FlowProject class
    * Moved all call logic for FlowGroup to __call__ method
    * Moved exec_mode command-line argument conversion to string to _main
    functions.
    * Changed logic in _verify_group_compatibility using python's set type
    * renamed submit_operations group argument to operations
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6530e1b View commit details
    Browse the repository at this point in the history
  14. Changing _verify_group_compatibility logic.

    * Also doing linting changes that flake8 requested.
    * The changes to the `_setup_template_environment` were required to
    commit with the flake8 commit hook.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    2ccfaeb View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1d97f5b View commit details
    Browse the repository at this point in the history
  16. Working on fixing bugs unit tests reveal.

    * Also adding exec mode to relevant tests.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    8c58b26 View commit details
    Browse the repository at this point in the history
  17. Changing run behavior always to exec mode.

    * Since operations are always expanded from groups before-hand, exec
    mode is the correct mode to be in when calling a run command.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    1b5b878 View commit details
    Browse the repository at this point in the history
  18. Changing groups behavior to pass tests.

    * Changing the `get_id` function in `FlowGroup` class to match previous
    id in the case of single operation groups.
    * Changing `_dumps_op` and `_loads_op` functions to include
    `JobOperation` id since it is now an attribute.
    * Created a function `_gather_FlowGroups` that takes a list of
    group/operation names and returns a list of instances of `FlowGroups`
    with removed duplication and error checking.
    * Add argument `mode` to submit function. Previously a kwarg check was
    preformed. This changes behavior to use the string which is the behavior
    elsewhere.
    	* _main_submit was changed to pass the string to submit as well.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    be46aae View commit details
    Browse the repository at this point in the history
  19. Added small changes in tests to match new implementations.

    * All references to `JobOperation.get_id()` are changed to use the
    attribute `id`.
    * Calls to `script` and `submit` that check output have 'exec' mode
    explicitly set.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    c024270 View commit details
    Browse the repository at this point in the history
  20. Fixing error in retrieving function path.

    * Including inheritance hierarchy in gathering operation functions.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6799e08 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    38347b6 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    f9d9813 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    a8a549c View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    c074f55 View commit details
    Browse the repository at this point in the history
  25. Adding regex support for selecting groups and operations

    * had to refactor operation selection to include fullmatch.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d956c12 View commit details
    Browse the repository at this point in the history
  26. Making groups resubmit safe

    * Also adding necessary tests for group behavior in submit, run, and
    script
    * Added `operation_ids` as attribute of JobOperation to hold individual
    operation ids for resubmitting checks.
    * Added `eligible_for_submission` method for JobOperaiton to check if
    all operation are not currently submitted.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    64ca5ab View commit details
    Browse the repository at this point in the history
  27. Test main_submit and change dynamic tests

    * For dynamic tests a workflow with multiple steps is tested. For the
    groups test, it is more important to show that resubmission is not
    possible. The multistep workflow is shown to work in the previous tests.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    e25fe3d View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    201314d View commit details
    Browse the repository at this point in the history
  29. test_main_submit for groups with with multiple calls.

    This is necessary since one assertIn command cannot be used to ensure
    all operations are in the command as the ordering in python version 3.5
    is not commensurate with python > 3.5.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    6e2d608 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    9700f77 View commit details
    Browse the repository at this point in the history
  31. Singleton FlowGroups and move directives to FlowGroups

    * Currently the singleton groups must have the same name as the
    operation name. As this is not changable by the user that should be
    okay.
    * I had to set the directives 'executable' and 'override_path' for
    singleton groups with the `@cmd` decorator. This results in some ugly
    logic that should work, but if there is an easier way should change.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    d7df58b View commit details
    Browse the repository at this point in the history
  32. Remove group specific status.

    * Removed group status from `set_status` command.
    * Redefined `JobOperation.get_status` to always return a list of
      operation statuses.
    * Logic has yet to be moved to `FlowProject`. I did not see a clear way
      to query whether a particular job-operation pair was currently submitted
      other than directly searching the project.
    * The test change was just to correct for the fact that now `get_status`
      returns a list.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    5c8de16 View commit details
    Browse the repository at this point in the history
  33. Move schedule status checks to group level.

    * Also show operation status through querying group status and expanding
      to composing operations.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    45ef91c View commit details
    Browse the repository at this point in the history
  34. Fix cmd-operations.

    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    a28b862 View commit details
    Browse the repository at this point in the history
  35. Initial check for prior group submission

    * Prevents unnecessary checking if the same group is previously submitted
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3a524a4 View commit details
    Browse the repository at this point in the history
  36. Create two paths for gathering JobOperations

    * One path for submission
    * One path for running
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    c2996b1 View commit details
    Browse the repository at this point in the history
  37. Remove obsolete doc-string entry.

    There is actually no need to further specify what the id *should* look
    like. It must be unique, that is the only requirement.
    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    e165321 View commit details
    Browse the repository at this point in the history
  38. Fix JobOperation.__repr__().

    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    accc0b3 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    fa8664f View commit details
    Browse the repository at this point in the history
  40. Reorganize the FlowGroup exec mode exception flow.

    1. Raise error at the point of assumption.
    2. Use dedicated exception class to propagate error.
    3. Raise SubmitError only during submission.
    4. Raise ScriptError during script generation.
    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3e279a5 View commit details
    Browse the repository at this point in the history
  41. Refactor run-cmd generation and fix one bug.

      * Simplified logic.
      * Use the group name as argument to -o in all cases.
    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b74530d View commit details
    Browse the repository at this point in the history
  42. Misc. improvements and optimizations.

    csadorf authored and b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    a140790 View commit details
    Browse the repository at this point in the history
  43. Change finding of FlowGroup path to use stack.

    * may need to change again but fixed a bug on my computer.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    37adda7 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    06dde88 View commit details
    Browse the repository at this point in the history
  45. Change test strings to match new output and new pathfinding method

    * New pathfinding method solves some problems but doesn't resolve all of
      them. Namely, for our tests the 'path' is always the test file.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    3005c35 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    429ec3e View commit details
    Browse the repository at this point in the history
  47. Refactor run logic in FlowGroups.

    * Remove six.PY2 testing
    * Fix rebase errors
    * Remove old function to find operation path
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    f014d67 View commit details
    Browse the repository at this point in the history
  48. Adding path and entrypoint attributes to FlowProject.

    * Test work again with minor refactoring to account for this new API.
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    cf7f416 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    e036139 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    b707ad5 View commit details
    Browse the repository at this point in the history
  51. Update flow/errors.py

    Co-Authored-By: Carl Simon Adorf <csadorf@umich.edu>
    b-butler and csadorf committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    daabf0d View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    f0e42ca View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    9f97ccf View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    b46e437 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    2f8fb09 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    7611b48 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    16f44ea View commit details
    Browse the repository at this point in the history
  58. Reverting make_bundles

    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    4c71372 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    cc3fc01 View commit details
    Browse the repository at this point in the history
  60. Fixing store_bundled bug

    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    a188859 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    ab85817 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    1fe7a2a View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    0fe3694 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    bdac061 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    738e9a9 View commit details
    Browse the repository at this point in the history
  66. Add documentation

    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    9a3efd8 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    73247f2 View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    98069e9 View commit details
    Browse the repository at this point in the history
  69. Add fork whitelisting from directives

    * Rebasing missed this
    b-butler committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    b6721c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2020

  1. Configuration menu
    Copy the full SHA
    7868988 View commit details
    Browse the repository at this point in the history
  2. Fix errors introduced by merge.

    Involved FlowGroups respecting ignore conditions
    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    420266d View commit details
    Browse the repository at this point in the history
  3. Fix typos and style errors

    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    ce5b70e View commit details
    Browse the repository at this point in the history
  4. Cleanup FlowGroup some

    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    242aa71 View commit details
    Browse the repository at this point in the history
  5. Change FlowGroup.intersects to FlowGroup.isdisjoint

    Matches set API better
    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    be074e3 View commit details
    Browse the repository at this point in the history
  6. Fix typo in function name

    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    9e999aa View commit details
    Browse the repository at this point in the history
  7. Move checking of conflicting group names earlier

    Now at the time of group functor name conflict is checked.
    b-butler committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    05fbcc1 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2020

  1. Configuration menu
    Copy the full SHA
    d635b83 View commit details
    Browse the repository at this point in the history
  2. Remove exec mode

    Templates still broken.
    b-butler committed Feb 2, 2020
    Configuration menu
    Copy the full SHA
    869bdf7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    093371c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c0d4266 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. Configuration menu
    Copy the full SHA
    80577df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d12359 View commit details
    Browse the repository at this point in the history
  3. Add operations to FlowProject._GROUP_NAMES

    prevents users from having a group named the same as an operation since
    singleton groups with operation name are automatically defined, and
    shadowing should not be allowed.
    b-butler committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    2e02a53 View commit details
    Browse the repository at this point in the history
  4. Change group registering logic

    No longer recompute the operation list from `_collect_operations`
    Also remove ExecCommandError
    b-butler committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    f698999 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    c2a6dd6 View commit details
    Browse the repository at this point in the history
  2. Change Stampede2Environment for group parallel jobs

    will currently break with bundling.
    b-butler committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    71fa088 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Configuration menu
    Copy the full SHA
    17af8ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c62ce2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad90478 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. Update flow/project.py

    Co-Authored-By: Bradley Dice <bdice@bradleydice.com>
    b-butler and bdice committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    b1dbdd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Configuration menu
    Copy the full SHA
    3d24889 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Create FlowGroupEntry class

    Has two decoraters ``__call__`` and ``with_directives``.
    b-butler committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    12f8268 View commit details
    Browse the repository at this point in the history
  2. Convert groups branch to pytest

    Also merge from master
    b-butler committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    89bbf26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    141846e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dfa078d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f24422f View commit details
    Browse the repository at this point in the history
  6. Update creation of submission JobOperations

    Remove directives from _submit_cmd
    
    Reduce noise in submission directives when 'ngpu', 'nranks',
    or 'omp_num_threads' is set to 0
    b-butler committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    12b629c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5d99a58 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    94fbab4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a839f82 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    34818d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Apply suggestions from code review

    Co-Authored-By: Carl Simon Adorf <csadorf@umich.edu>
    Co-Authored-By: vyasr <vramasub@umich.edu>
    3 people committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    7099e8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4db0a8b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41fe27c View commit details
    Browse the repository at this point in the history
  4. Update *Operation docstrings and FlowGroup docstrings

    Also edit other comments
    b-butler committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    da46f51 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9d5e774 View commit details
    Browse the repository at this point in the history
  6. Remove redundant calls to .keys() for dict

    * the buildin __contains__ or __iter__ is faster.
    b-butler committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    dd13329 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4d79dfa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    23cbc22 View commit details
    Browse the repository at this point in the history
  9. Change entrpoint priority

    b-butler committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    302d1ce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3b6f613 View commit details
    Browse the repository at this point in the history
  11. Style changes

    b-butler committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    f2aab3a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6942f92 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    94adc2f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    23fde7c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    bead718 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Apply suggestions from code review

    Co-Authored-By: Carl Simon Adorf <csadorf@umich.edu>
    b-butler and csadorf committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    2bb298b View commit details
    Browse the repository at this point in the history
  2. Return function after FlowGroupEntry decorator

    Before we did not return the function back at the end
    b-butler committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    ee97036 View commit details
    Browse the repository at this point in the history
  3. Add FlowGroup to docs

    b-butler committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    eb2c7eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8a74ac2 View commit details
    Browse the repository at this point in the history
  5. Edit docstrings and change argument name

    Use ignore_conditions_on_execution instead of
    ignore_conditions_on_submit
    b-butler committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    e7b1670 View commit details
    Browse the repository at this point in the history
  6. Fix bug with get_status

    b-butler committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    ec7b7a2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fe69407 View commit details
    Browse the repository at this point in the history
  8. Update tests for using groups

    I had to add operations to the project classes so some tests needed to
    be updated
    b-butler committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    9991800 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d3c1894 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5e32098 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    31fee5a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f4ca176 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    404bf84 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2020

  1. Configuration menu
    Copy the full SHA
    871510e View commit details
    Browse the repository at this point in the history
  2. Fix errors with testing

    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    1cf6c6b View commit details
    Browse the repository at this point in the history
  3. Fix error on CI.

    Entrypoints require we first cd into the test directory
    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    aee0fe0 View commit details
    Browse the repository at this point in the history
  4. Revert "Fix error on CI."

    This reverts commit aee0fe0.
    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    12fd2b8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f28e386 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    98ff1f1 View commit details
    Browse the repository at this point in the history
  7. Apply suggestions from code review

    Co-Authored-By: Bradley Dice <bdice@bradleydice.com>
    Co-Authored-By: Carl Simon Adorf <csadorf@umich.edu>
    3 people committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    3ac8463 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    00328e8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dcc697e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a61e57b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    60c31d1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b2320d5 View commit details
    Browse the repository at this point in the history
  13. Update docstrings, help strings, and comments

    Also one style change
    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    a07aace View commit details
    Browse the repository at this point in the history
  14. Only add --ignore-conditions when necessary

    Add logic to FlowGroup._sumbit_cmd
    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    a9e2351 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a3633c7 View commit details
    Browse the repository at this point in the history
  16. Fix test to work with python 3.5

    Status's with groups are sorted by operation name (this is due to
    operation status having to be grabbed through groups). We sort the
    output. This just makes the test do the same
    b-butler committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    351f481 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4b3c2bd View commit details
    Browse the repository at this point in the history
  18. Update flow/project.py

    Co-Authored-By: Bradley Dice <bdice@bradleydice.com>
    b-butler and bdice committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    f41f09a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Fix FlowGroup.options and __repr__

    Add test for __repr__
    b-butler committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    ee45c0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d61ef2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    02ecd0e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3165989 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. Update flow/project.py

    Co-Authored-By: vyasr <vramasub@umich.edu>
    b-butler and vyasr committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    1ab20b0 View commit details
    Browse the repository at this point in the history
  2. Update FlowGroup API docs

    b-butler committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    d312619 View commit details
    Browse the repository at this point in the history
  3. Update template tests

    b-butler committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    8b80519 View commit details
    Browse the repository at this point in the history
  4. final changes

    b-butler committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    b63c252 View commit details
    Browse the repository at this point in the history
  5. change changelog

    b-butler committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    a82a77d View commit details
    Browse the repository at this point in the history