date change messages are chat_day_change color, multiple messages gerated for diff of 1-5 days #677
Conversation
…erated for diff of 1-5 days
| @@ -290,7 +290,7 @@ | |||
| var ret = {}; | |||
| var optionCode = parseInt(m[1]); | |||
|
|
|||
| if (optionCode > 43) { | |||
There was a problem hiding this comment.
why was this 43? seems an arbitrary number, and was smaller than the size of the color array
There was a problem hiding this comment.
(credit squirrel on IRC) 43 was actually the length, but for some reason using chat_day_change didn't work until I made this change. But then I tested it without this change just now and it works. I dunno what's up. In any case, it works and is a little bit more descriptive.
pmelanson
force-pushed
the
date-change
branch
4 times, most recently
from
19663da
to
30b564a
Compare
pmelanson
force-pushed
the
date-change
branch
from
30b564a
to
9955056
Compare
|
http://i.imgur.com/wt0x85V.png for demo of new 2date behaviour |
| @@ -20,12 +20,27 @@ weechat.factory('handlers', ['$rootScope', '$log', 'models', 'plugins', 'notific | |||
| }; | |||
|
|
|||
| // inject a fake buffer line for date change | |||
| var injectDateChangeMessage = function(message, buffer, date) { | |||
| var content = "Date changed to " + date.toDateString(); | |||
| var injectDateChangeMessage = function(message, buffer, d1, d2) { | |||
There was a problem hiding this comment.
d1 and d2 aren't particularly helpful variable names. We try to keep them as meaningful as possible, would you mind changing them to prev_date and curr_date or old_date and new_date or something along those lines? And maybe next_date or day_after_new/day_after_curr for d1_plus_one?
There was a problem hiding this comment.
thanks for catching this, this is going to be my new year's resolution
|
Very cool, I just have some minor odds and ends (see inline comments). Thanks! |
|
Ah wait the PR is for the date change branch, I'll fix it myself. |
date change messages are chat_day_change color, multiple messages gerated for diff of 1-5 days
|
I'm getting a "00:00 <──> Date changed to Sat Jun 27 2015 (1 days from Fri Jun 26 2015)" message in one of my buffers and I can't figure out why. Anyone got any ideas? (the date changed by two days, from Thu 25 to Sat 27) |
Has a weird bug: #677 (comment)
PR for discussion.
Two changes here,
js/weechat.js. I'll point that out in a line comment.http://i.imgur.com/7OGs1jF.png (sorry for imgur, git wasn't uploading it properly. I'm on greyhound bus wifi atm.)