Apply suggestions from code review

Co-authored-by: Adrien Clairembault <42734840+AdrienClairembault@users.noreply.github.com>
glpi-project · May 22, 2024 · 09b9435 · 09b9435
1 parent 0b03c0c
commit 09b9435
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/css/includes/components/form/_form-editor.scss b/css/includes/components/form/_form-editor.scss
@@ -160,7 +160,7 @@
 
 [data-glpi-form-editor-comment] {
     &[data-glpi-form-editor-active-comment] {
-        // Show secondary data on active form
+        // Show secondary data on active comments
         [data-glpi-form-editor-comment-extra-details] {
             opacity: 1;
             visibility: visible;
@@ -169,12 +169,12 @@
     }
 
     &:not([data-glpi-form-editor-active-comment]) {
-        // Do not highlight inactive forms
+        // Do not highlight inactive comments
         [data-glpi-form-editor-active-comment-status-indicator] {
             display: none;
         }
 
-        // Do not show secondary data on inactive form
+        // Do not show secondary data on inactive comments
         [data-glpi-form-editor-comment-extra-details] {
             height: 0;
             opacity: 0;

diff --git a/src/Form/Block.php b/src/Form/Block.php
@@ -35,7 +35,7 @@
 
 namespace Glpi\Form;
 
-interface Block
+interface BlockInterface
 {
     public function displayBlockForEditor(): void;
 }
diff --git a/src/Form/Comment.php b/src/Form/Comment.php
@@ -43,7 +43,7 @@
 /**
  * Comment of a given helpdesk form's section
  */
-final class Comment extends CommonDBChild implements Block
+final class Comment extends CommonDBChild implements BlockInterface
 {
     public static $itemtype = Section::class;
     public static $items_id = 'forms_sections_id';

diff --git a/src/Form/Question.php b/src/Form/Question.php
@@ -46,7 +46,7 @@
 /**
  * Question of a given helpdesk form's section
  */
-final class Question extends CommonDBChild implements Block
+final class Question extends CommonDBChild implements BlockInterface
 {
     public static $itemtype = Section::class;
     public static $items_id = 'forms_sections_id';

diff --git a/templates/pages/admin/form/form_comment.html.twig b/templates/pages/admin/form/form_comment.html.twig
@@ -72,7 +72,7 @@
                     class="form-control content-editable-h2 mb-0"
                     type="text"
                     name="name"
-                    value="{{ comment is not null ? comment.fields.name|e('html_attr') : '' }}"
+                    value="{{ comment is not null ? comment.fields.name : '' }}"
                     placeholder="{{ __("Add a title...") }}"
                     aria-label="{{ __("Comment title") }}"
                     data-glpi-form-editor-dynamic-input
@@ -115,7 +115,7 @@
             </div>
 
             <div
-                class="d-flex flex-row-reverse align-items-center mt-2"
+                class="d-flex flex-row-reverse align-items-center"
                 data-glpi-form-editor-comment-extra-details
             >
                 <button