Fix forcetab parameter for namespaces (#14513)

* Fix forcetab parameter for namespaces

* Revert "Fix forcetab parameter for namespaces"

This reverts commit 4d05710.

* Fix regex that detect namespaces

* Update src/Toolbox/Sanitizer.php

---------

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>

src/Toolbox/Sanitizer.php

@@ -219,6 +219,7 @@ public static function isDbEscaped(string $value): bool
 
     /**
      * Check wether the value correspond to a valid namespaced class (or a callable identifier related to a valid class).
+     * Note: also support the {namespace}${tab number} format used for tab identifications
      *
      * @param string $value
      *
@@ -227,8 +228,12 @@ public static function isDbEscaped(string $value): bool
     public static function isNsClassOrCallableIdentifier(string $value): bool
     {
         $class_match = [];
-        return preg_match('/^(?<class>(([a-zA-Z0-9_]+\\\)+[a-zA-Z0-9_]+))(:?:[a-zA-Z0-9_]+)?$/', $value, $class_match)
-            && class_exists($class_match['class']);
+
+        return preg_match(
+            '/^(?<class>(([a-zA-Z0-9_]+\\\)+[a-zA-Z0-9_]+))(:?:[a-zA-Z0-9_]+)?(\$[0-9]+)?$/',
+            $value,
+            $class_match
+        ) && class_exists($class_match['class']);
     }
 
     /**

tests/units/Glpi/Toolbox/Sanitizer.php

@@ -618,6 +618,10 @@ protected function isNsClassOrCallableIdentifierProvider(): iterable
             'value'    => 'Glpi\\\\Socket',
             'is_class' => false, // namespace separator are escaped, so it is not considered as a valid classname
         ];
+        yield [
+            'value'    => 'Glpi\Dashboard\Dashboard$1',
+            'is_class' => true, // special format for tab names
+        ];
     }
 
     /**