Add locations_id to items_devicecamera

fixes #16561

inc/relation.constant.php

@@ -858,6 +858,7 @@
         'glpi_devicesensors'             => 'locations_id',
         'glpi_enclosures'                => 'locations_id',
         'glpi_items_devicebatteries'     => 'locations_id',
+        'glpi_items_devicecameras'       => 'locations_id',
         'glpi_items_devicecases'         => 'locations_id',
         'glpi_items_devicecontrols'      => 'locations_id',
         'glpi_items_devicedrives'        => 'locations_id',

install/migrations/update_10.0.12_to_10.0.13/location.php

@@ -0,0 +1,43 @@
+<?php
+
+/**
+ * ---------------------------------------------------------------------
+ *
+ * GLPI - Gestionnaire Libre de Parc Informatique
+ *
+ * http://glpi-project.org
+ *
+ * @copyright 2015-2024 Teclib' and contributors.
+ * @copyright 2003-2014 by the INDEPNET Development Team.
+ * @licence   https://www.gnu.org/licenses/gpl-3.0.html
+ *
+ * ---------------------------------------------------------------------
+ *
+ * LICENSE
+ *
+ * This file is part of GLPI.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ * ---------------------------------------------------------------------
+ */
+
+/**
+ * @var \Migration $migration
+ */
+
+$migration->addField('glpi_items_devicecameras', 'locations_id', "fkey", [
+    'after'  => 'is_recursive',
+]);
+$migration->addKey('glpi_items_devicecameras', 'locations_id');

install/mysql/glpi-empty.sql

@@ -1984,13 +1984,15 @@ CREATE TABLE `glpi_items_devicecameras` (
   `is_dynamic` tinyint NOT NULL DEFAULT '0',
   `entities_id` int unsigned NOT NULL DEFAULT '0',
   `is_recursive` tinyint NOT NULL DEFAULT '0',
+  `locations_id` int unsigned NOT NULL DEFAULT '0',
   PRIMARY KEY (`id`),
   KEY `items_id` (`items_id`),
   KEY `devicecameras_id` (`devicecameras_id`),
   KEY `is_deleted` (`is_deleted`),
   KEY `is_dynamic` (`is_dynamic`),
   KEY `entities_id` (`entities_id`),
   KEY `is_recursive` (`is_recursive`),
+  KEY `locations_id` (`locations_id`),
   KEY `item` (`itemtype`,`items_id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci ROW_FORMAT=DYNAMIC;
 

tests/functional/Glpi/Inventory/Inventory.php

@@ -5527,6 +5527,7 @@ public function testImportPhone()
                     'is_dynamic' => 1,
                     'entities_id' => 0,
                     'is_recursive' => 0,
+                    'locations_id' => 0,
                 ], [
                     'items_id' => $phones_id,
                     'itemtype' => 'Phone',
@@ -5535,6 +5536,7 @@ public function testImportPhone()
                     'is_dynamic' => 1,
                     'entities_id' => 0,
                     'is_recursive' => 0,
+                    'locations_id' => 0,
                 ]
             ]
         ];

tests/functional/Location.php

@@ -316,4 +316,14 @@ public function testImport(array $input, array $imported): void
             $this->integer(countElementsInTable(\Location::getTable(), $location_data))->isEqualTo(1, json_encode($location_data));
         }
     }
+
+    public function testMaybeLocated()
+    {
+        global $CFG_GLPI;
+
+        foreach ($CFG_GLPI['location_types'] as $type) {
+            $item = new $type();
+            $this->boolean($item->maybeLocated())->isTrue($type . ' cannot be located!');
+        }
+    }
 }