Fix category metadata in itil kanban cards

glpi-project · Mar 11, 2024 · fee22be · fee22be
1 parent adadc73
commit fee22be
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/src/CommonITILObject.php b/src/CommonITILObject.php
@@ -9199,23 +9199,11 @@ public static function getDataToDisplayOnKanban($ID, $criteria = [])
             }
         }
 
-        $category_names = [];
         foreach ($common_itil_iterator as $data) {
-            if (!array_key_exists($data['itilcategories_id'], $category_names)) {
-                $category_name = DropdownTranslation::getTranslatedValue(
-                    $data['itilcategories_id'],
-                    ITILCategory::class
-                );
-                if ($category_name === '') {
-                    $category_name = ITILCategory::getFriendlyNameById($data['itilcategories_id']);
-                }
-
-                $category_names[$data['itilcategories_id']] = $category_name;
-            }
             $data = [
                 'id'        => $data['id'],
                 'name'      => $data['name'],
-                'category'  => $category_names[$data['itilcategories_id']] ?? '',
+                'category'  => $data['itilcategories_id'],
                 'content'   => $data['content'],
                 'status'    => $data['status'],
                 '_itemtype' => $itemtype,
@@ -9403,7 +9391,10 @@ public static function getKanbanColumns($ID, $column_field = null, $column_ids =
 
         // Replace category ids with category names in items metadata
         foreach ($columns as &$column) {
-            foreach (($column['items'] ?? []) as &$item) {
+            if (!isset($column['items'])) {
+                continue;
+            }
+            foreach ($column['items'] as &$item) {
                 $item['_metadata']['category'] = $categories[$item['_metadata']['category']] ?? '';
             }
         }