Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock blocks post-only user to add followup #1000

Closed
trasher opened this issue Sep 16, 2016 · 7 comments
Closed

Lock blocks post-only user to add followup #1000

trasher opened this issue Sep 16, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@trasher
Copy link
Contributor

trasher commented Sep 16, 2016

When locking is enable in the configuration, it works as expected with a tech user, but no lock is set for post-only users.

pinf @tomolimo

@trasher trasher added the bug label Sep 16, 2016
@trasher trasher added this to the 9.1 milestone Sep 16, 2016
@trasher trasher self-assigned this Sep 16, 2016
@tomolimo
Copy link
Contributor

That's by design, post-only users are not locking items, see #54 for more information about design of lock mechanism. Not sure if this was specifically explained.

@trasher
Copy link
Contributor Author

trasher commented Sep 16, 2016

Thank you.

As far as I can see, specific "post-only" case has not been discussed; so, should we add lock on post-only ? Thoughts?

@tomolimo
Copy link
Contributor

Then that was forgotten from my side in the #54 issue.
But for me 'post-only' users are not concerned by the lock as they my add followups at any time. In our GLPi we prevent them from editing followups:

image

As the only risk is when a 'post-only' user is going to edit its own followups, the risk of collision is really reduced, I propose to let this like that and to wait for feedbacks from the GLPi global use.

@trasher
Copy link
Contributor Author

trasher commented Sep 16, 2016

As far as I know, there actually are issues; the user will be denied to add a new followup.

I'll take a deeper look at all of this.

@tomolimo
Copy link
Contributor

then if he is really denied from adding a followup: this is a bug, as by design he should be able as 'post-only' to add a followup, even if ticket is locked by a tech.

@flegastelois
Copy link
Member

Hi @ALL,

I confirm that @trasher says, the user will be denied to add a new followup :
https://share.teclib.net/data/public/8ae5d4

@trasher trasher changed the title Lock not set for post-only user Lock blocks post-only user to add followup Sep 16, 2016
@trasher
Copy link
Contributor Author

trasher commented Sep 16, 2016

Thanks @flegastelois :) @tomolimo yes, sounds like a bug; I've edited ticket title, I'll try to fix. Thanks you for the clarifiactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants