Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser notification don't work #10612

Closed
2 tasks done
tksadmin opened this issue Feb 11, 2022 · 7 comments
Closed
2 tasks done

Browser notification don't work #10612

tksadmin opened this issue Feb 11, 2022 · 7 comments
Labels
beta

Comments

@tksadmin
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

Is there an existing issue for this?

  • I have searched the existing issues

Version

[GLPI 10.0.0-rc1]

Bug description

AJAX notifications seems to be ignored and sent always like a mail.
When I send a test browser notification nothing happens.
I can see it in the notification queue, but when I try to force sending, it throws an error, attached in the log output.
This seems to happen everytime for every notification, also for the custom ones.

Relevant log output

[2022-02-11 17:43:01] glpiphplog.WARNING:   *** PHP User Warning (512): NotificationEventAjax::send should not be called! in /var/www/html/glpi/src/NotificationEventAjax.php at line 80
  Backtrace :
  src/NotificationEventAjax.php:80                   trigger_error()
  src/QueuedNotification.php:462                     NotificationEventAjax::send()
  src/QueuedNotification.php:102                     QueuedNotification->sendById()
  src/MassiveAction.php:1168                         QueuedNotification::processMassiveActionsForOneItemtype()
  src/MassiveAction.php:1146                         MassiveAction->processForSeveralItemtypes()
  front/massiveaction.php:59                         MassiveAction->process()

Page URL

No response

Steps To reproduce

Setup -> Notifications -> Browser followups configuration -> Send a test browser notification to you -> Nothing happens

Administration -> Notification Queue -> Click on the generated notification -> Actions -> Send -> Post -> Error

image

---- This happens also with custom notifies

Setup -> Notifications -> Notifications Template -> Add -> Name:test, Type:ticket -> Add -> Subject:test, Email text body:test -> Add
Setup -> Notifications -> Notifications -> Add -> Name:test, Active:yes, Type:ticket, Event:New Ticket -> Save -> Templates -> Add a Template, select previous created template, Mode:Browser, recipient:super-admin

image

Your GLPI setup information

Information about system installation and configuration
GLPI 10.0.0-dev ( => /var/www/html/glpi)
Installation mode: TARBALL
Current language:en_GB
Server
 
Operating system: Linux glpi 5.4.140-1-pve #1 SMP PVE 5.4.140-1 (Wed, 08 Sep 2021 16:21:59 +0200) x86_64
PHP 7.4.25 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apc, apcu, bz2,
	calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, intl, json, ldap, libxml, mbstring,
	mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, readline, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem,
	sysvshm, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, zlib)
Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files"
	upload_max_filesize="2M" 
Software: Apache/2.4.52 (Debian) (Apache/2.4.52 (Debian) Server at *** Port 443
)
	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.82 Safari/537.36
Server Software: Debian 11
	Server Version: 10.5.12-MariaDB-0+deb11u1
	Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
	Parameters: glpi@localhost/glpi
	Host info: Localhost via UNIX socket

PHP version (7.4.25) is supported.

Sessions configuration is OK.

Allocated memory is sufficient.

mysqli extension is installed.

Following extensions are installed: dom, fileinfo, json, simplexml.

curl extension is installed.

gd extension is installed.

intl extension is installed.

libxml extension is installed.

zlib extension is installed.

Database engine version (10.5.12) is supported.

The log file has been created successfully.

Write access to /var/www/html/glpi/files/_cache has been validated.

Write access to /var/www/html/glpi/config has been validated.

Write access to /var/www/html/glpi/files/_cron has been validated.

Write access to /var/www/html/glpi/files has been validated.

Write access to /var/www/html/glpi/files/_dumps has been validated.

Write access to /var/www/html/glpi/files/_graphs has been validated.

Write access to /var/www/html/glpi/files/_lock has been validated.

Write access to /var/www/html/glpi/files/_pictures has been validated.

Write access to /var/www/html/glpi/files/_plugins has been validated.

Write access to /var/www/html/glpi/files/_rss has been validated.

Write access to /var/www/html/glpi/files/_sessions has been validated.

Write access to /var/www/html/glpi/files/_tmp has been validated.

Write access to /var/www/html/glpi/files/_uploads has been validated.

Web access to the files directory should not be allowed

Check the .htaccess file and the web server configuration.

exif extension is installed.

ldap extension is installed.

openssl extension is installed.

zip extension is installed.

bz2 extension is installed.

Zend OPcache extension is installed.

Following extensions are installed: ctype, iconv, mbstring, sodium.

Write access to /var/www/html/glpi/marketplace has been validated.

Timezones seems not loaded, see https://glpi-install.readthedocs.io/en/latest/timezones.html.
GLPI constants
 
GLPI_ROOT: /var/www/html/glpi
GLPI_CONFIG_DIR: /var/www/html/glpi/config
GLPI_VAR_DIR: /var/www/html/glpi/files
GLPI_MARKETPLACE_DIR: /var/www/html/glpi/marketplace
GLPI_USE_CSRF_CHECK: 1
GLPI_CSRF_EXPIRES: 7200
GLPI_CSRF_MAX_TOKENS: 100
GLPI_USE_IDOR_CHECK: 1
GLPI_IDOR_EXPIRES: 7200
GLPI_ALLOW_IFRAME_IN_RICH_TEXT: 
GLPI_TELEMETRY_URI: https://telemetry.glpi-project.org
GLPI_INSTALL_MODE: TARBALL
GLPI_NETWORK_MAIL: glpi@teclib.com
GLPI_NETWORK_SERVICES: https://services.glpi-network.com
GLPI_MARKETPLACE_ALLOW_OVERRIDE: 1
GLPI_MARKETPLACE_MANUAL_DOWNLOADS: 1
GLPI_USER_AGENT_EXTRA_COMMENTS: 
GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: 1
GLPI_AJAX_DASHBOARD: 1
GLPI_CALDAV_IMPORT_STATE: 0
GLPI_DEMO_MODE: 0
GLPI_DOC_DIR: /var/www/html/glpi/files
GLPI_CACHE_DIR: /var/www/html/glpi/files/_cache
GLPI_CRON_DIR: /var/www/html/glpi/files/_cron
GLPI_DUMP_DIR: /var/www/html/glpi/files/_dumps
GLPI_GRAPH_DIR: /var/www/html/glpi/files/_graphs
GLPI_LOCAL_I18N_DIR: /var/www/html/glpi/files/_locales
GLPI_LOCK_DIR: /var/www/html/glpi/files/_lock
GLPI_LOG_DIR: /var/www/html/glpi/files/_log
GLPI_PICTURE_DIR: /var/www/html/glpi/files/_pictures
GLPI_PLUGIN_DOC_DIR: /var/www/html/glpi/files/_plugins
GLPI_RSS_DIR: /var/www/html/glpi/files/_rss
GLPI_SESSION_DIR: /var/www/html/glpi/files/_sessions
GLPI_TMP_DIR: /var/www/html/glpi/files/_tmp
GLPI_UPLOAD_DIR: /var/www/html/glpi/files/_uploads
GLPI_INVENTORY_DIR: /var/www/html/glpi/files/_inventories
GLPI_NETWORK_REGISTRATION_API_URL: https://services.glpi-network.com/api/registration/
GLPI_MARKETPLACE_PLUGINS_API_URI: https://services.glpi-network.com/api/glpi-plugins/
GLPI_I18N_DIR: /var/www/html/glpi/locales
GLPI_VERSION: 10.0.0-dev
GLPI_SCHEMA_VERSION: 10.0.0-dev@5d5ed159d30f08ffa4fb9065d7c3f64855d5d4e1
GLPI_MARKETPLACE_PRERELEASES: 1
GLPI_MIN_PHP: 7.4.0
GLPI_YEAR: 2021
Libraries
 
htmlawed/htmlawed version 1.2.6 in (/var/www/html/glpi/vendor/htmlawed/htmlawed)
phpmailer/phpmailer version 6.5.3 in (/var/www/html/glpi/vendor/phpmailer/phpmailer/src)
simplepie/simplepie version 1.5.6 in (/var/www/html/glpi/vendor/simplepie/simplepie/library)
mpdf/mpdf in (/var/www/html/glpi/vendor/mpdf/mpdf/src)
michelf/php-markdown in (/var/www/html/glpi/vendor/michelf/php-markdown/Michelf)
true/punycode in (/var/www/html/glpi/vendor/true/punycode/src)
iamcal/lib_autolink in (/var/www/html/glpi/vendor/iamcal/lib_autolink)
sabre/dav in (/var/www/html/glpi/vendor/sabre/dav/lib/DAV)
sabre/http in (/var/www/html/glpi/vendor/sabre/http/lib)
sabre/uri in (/var/www/html/glpi/vendor/sabre/uri/lib)
sabre/vobject in (/var/www/html/glpi/vendor/sabre/vobject/lib)
laminas/laminas-i18n in (/var/www/html/glpi/vendor/laminas/laminas-i18n/src)
laminas/laminas-servicemanager in (/var/www/html/glpi/vendor/laminas/laminas-servicemanager/src)
monolog/monolog in (/var/www/html/glpi/vendor/monolog/monolog/src/Monolog)
sebastian/diff in (/var/www/html/glpi/vendor/sebastian/diff/src)
elvanto/litemoji in (/var/www/html/glpi/vendor/elvanto/litemoji/src)
symfony/console in (/var/www/html/glpi/vendor/symfony/console)
scssphp/scssphp in (/var/www/html/glpi/vendor/scssphp/scssphp/src)
laminas/laminas-mail in (/var/www/html/glpi/vendor/laminas/laminas-mail/src/Protocol)
laminas/laminas-mime in (/var/www/html/glpi/vendor/laminas/laminas-mime/src)
rlanvin/php-rrule in (/var/www/html/glpi/vendor/rlanvin/php-rrule/src)
blueimp/jquery-file-upload in (/var/www/html/glpi/vendor/blueimp/jquery-file-upload/server/php)
ramsey/uuid in (/var/www/html/glpi/vendor/ramsey/uuid/src)
psr/log in (/var/www/html/glpi/vendor/psr/log/Psr/Log)
psr/simple-cache in (/var/www/html/glpi/vendor/psr/simple-cache/src)
psr/cache in (/var/www/html/glpi/vendor/psr/cache/src)
league/csv in (/var/www/html/glpi/vendor/league/csv/src)
mexitek/phpcolors in (/var/www/html/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors)
guzzlehttp/guzzle in (/var/www/html/glpi/vendor/guzzlehttp/guzzle/src)
guzzlehttp/psr7 in (/var/www/html/glpi/vendor/guzzlehttp/psr7/src)
glpi-project/inventory_format in (/var/www/html/glpi/vendor/glpi-project/inventory_format/lib/php)
wapmorgan/unified-archive in (/var/www/html/glpi/vendor/wapmorgan/unified-archive/src)
paragonie/sodium_compat in (/var/www/html/glpi/vendor/paragonie/sodium_compat/src)
symfony/cache in (/var/www/html/glpi/vendor/symfony/cache)
html2text/html2text in (/var/www/html/glpi/vendor/html2text/html2text/src)
symfony/dom-crawler in (/var/www/html/glpi/vendor/symfony/dom-crawler)
twig/twig in (/var/www/html/glpi/vendor/twig/twig/src)
twig/string-extra in (/var/www/html/glpi/vendor/twig/string-extra)
symfony/polyfill-ctype not found
symfony/polyfill-iconv not found
symfony/polyfill-mbstring not found
symfony/polyfill-php80 in (/var/www/html/glpi/vendor/symfony/polyfill-php80)
SQL replicas
 
Not active
Notifications
 
Way of sending emails: SMTP+TLS (noreply@****@smtp.office365.com)
Plugins list
 
	accounts             Name: Accounts                       Version: 3.0.0-rc2  State: Enabled
	fields               Name: Campi aggiuntivi               Version: 1.13.0-rc2 State: Installed / not activated
	formcreator          Name: Form Creator                   Version: 2.13.0-alpha.3 State: Enabled
	glpiinventory        Name: GLPI Inventory                 Version: 1.0.0-rc4  State: Not installed

Anything else?

No response
@cconard96 cconard96 added the beta label Feb 11, 2022
@leruetkins
Copy link

Confirm. I have no any notifications in browser.

@tksadmin
Copy link
Author

tksadmin commented Feb 15, 2022 •
edited

Ok, i digged a little bit further.
AJAX notifications seems to be loaded by static function loadJavascript() in Html.php (line 6171).
However, this function is called only in popFooter()

Adding

self::loadJavascript();

at the end of static footer() function in Html.php seems to fix the issue.

cedric-anne added a commit to cedric-anne/glpi that referenced this issue Feb 15, 2022
@cedric-anne
Fix browser notifications; fixes glpi-project#10612
6985d2a
@cedric-anne cedric-anne mentioned this issue Feb 15, 2022
Merged
@cedric-anne
Copy link
Member

Hi,

Could you check if #10664 fixes this issue ?

Regards

@tksadmin
Copy link
Author

Yes, it works!

Thank you

@cedric-anne cedric-anne reopened this Feb 15, 2022
@leruetkins
Copy link

leruetkins commented Feb 15, 2022 •
edited

Hmm

I have such nitification(
Screenshot_1

php-errors.log:
[2022-02-15 20:16:24] glpiphplog.WARNING: *** PHP User Warning (512): NotificationEventAjax::send should not be called! in /var/www/html/glpi/src/NotificationEventAjax.php at line 80
Backtrace :
src/NotificationEventAjax.php:80 trigger_error()
src/QueuedNotification.php:462 NotificationEventAjax::send()
src/QueuedNotification.php:102 QueuedNotification->sendById()
src/MassiveAction.php:1175 QueuedNotification::processMassiveActionsForOneItemtype()
src/MassiveAction.php:1153 MassiveAction->processForSeveralItemtypes()
front/massiveaction.php:57 MassiveAction->process()

@cedric-anne
Copy link
Member

#10679 should fix this. This notification is a browser notification, the "Send" action should not be proposed.

@cconard96 cconard96 mentioned this issue Feb 23, 2022
Closed
2 tasks
@jamersonsouza-novo
Copy link

hello friends, I tried the solution mentioned in the GLPI 10.0.0 release, however, without success, could you help me?

@jamersonsouza-novo jamersonsouza-novo mentioned this issue Nov 30, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leruetkins @cconard96 @cedric-anne @tksadmin @jamersonsouza-novo