[9.2] image insertion in mail ticket notification

[kelior]

Since the 9.2 upgrade, when we receive a mail notification on a ticket update,
the images linked in the ticket do not appear like they used to do :

Here is the result we get on the mail :

It seems the link to the docid is not complete.

[alias59]

Hello,
You have move the folder who containt the image after update ?
Regards

[kelior]

no if I access the full url (http://10.128.6.69/glpi/front/document.send.php?docid=3488) in my browser the image is displayed correctly.

[alias59]

Check rules the folder ( Write and Reader ) ?
In Ubuntu ( chmod -R 755 and chown -R www-data:www-data)

[alias59]

Check general configuration
address Web :

[kelior]

alright the problem is since version 9.2, you can insert images directly into the ticket with tinyMCE.
And it works by puttin an img tag like so
<img alt="a74e68b4-d9d62df8-59cca693a30978.38063338" height="106" width="289" src="/glpi/front/document.send.php?docid=3488">

When the notification is sent, the content of the ticket is copied in the mail with the same src.(missing the root)

[babaymaster]

as same problem. bad link image in ticket

[rjmontenegro]

Same on my installation 9.2 (happens on mailgate ticket creation):

IE

Chrome

[alias59]

@kelior, Have you find solution ?

[babaymaster]

no, wait new realease,,,,

[orthagh]

Hello guys,
We found a solution for this issue.
We embed image as attachments, the correction is #3085 and should be in 9.2.1 release.
So future mail notifications will work.

[orthagh]

And in #3092 (will be also released in 9.2.1) mail collect of inline pictures should work

[dbegit]

#3154
The problem is not resolve on 9.2.1
Url of img is wrong
http://srvglpi/var/www/html/glpi/front/document.send.php?docid=6481
instead of
http://srvglpi/front/document.send.php?docid=6481

[kelior]

It is fixed on my end

[rjmontenegro]

I'm still experiencing problems after upgrading to 9.2.1.

Ok, on notification after mailgate (new ticket).

Wrong, on ticket...

[ghost]

The problem probably comes from here :

Modify

• inc/html.class.php:5466
  $fullpath = GLPI_DOC_DIR."/".$image['filepath'];
  to
  $fullpath = "/".$image['filepath'];

[lekzz]

The inc/html.class.php:5466 fixes some of the issue but not all, inline mailed messages still have the wrong url, fix:

inc/html.class.php:5474

             if ($addLink) {
                $out .= '<a href="'.$CFG_GLPI['root_doc'].
                        '/front/document.send.php?docid='.$id.
                        '" target="_blank"><img alt="'.$image['tag'].
                        '" height="'.$height.'" width="'.$width.
                        '" src="'.$CFG_GLPI['root_doc'].
                   '/front/document.send.php?docid='.$id.'" /></a>';
             } else {
                $out .= '<img alt="'.$image['tag'].
                        '" height="'.$height.'" width="'.$width.
                        '" src="'.$CFG_GLPI['root_doc'].
                        '/front/document.send.php?docid='.$id.'" />';

to

             if ($addLink) {
                $out .= '<a href="/front/document.send.php?docid='.$id.
                        '" target="_blank"><img alt="'.$image['tag'].
                        '" height="'.$height.'" width="'.$width.
                        '" src="/front/document.send.php?docid='.$id.'" /></a>';
             } else {
                $out .= '<img alt="'.$image['tag'].
                        '" height="'.$height.'" width="'.$width.
                        '" src="/front/document.send.php?docid='.$id.'" />';

[lekzz]

Also it seems to mess up the email notifications with more then just one image.

When creating a new ticket or doing a follow up using the website with mutliple images only the first gets used in the notification.
But even funnier when doing the same using email, a preview of the 2nd image is shown in the mail. But when clicking on it you will be taken to the first image. Also the preview of the 2nd will have the dimensions of the first image.

Also it seems to want to resize/crop/whatever the first image using the website, but not the other images.

[ghost]

It does not work even by changing / removing variables, someone to an idea? Because it's still a critical function ... 👎

[lekzz]

The changes work for me but only on new uploaded images, not existing. Guess the generated tags are saved in the database.

[Claudissimo]

I have amended the inc/html.class.php file but it is still not working Under 9.2.1
We need a fix quickly guys please.

Thank you for your support

[okvok]

Hi. Confirm. The changes work. Thank you!

[SoluNeXT]

Hi everybody
Corrected the code for images previews problem in tickets. The RegEx replacement is not working correctly. As I'm not a regex pro, i've made str_replace corrections. Here are the lines modified :

File : inc/notificationeventmailing.class.php
Line : ~157

               foreach ($document_items as $doc_i_data) {
/* ADD LINE DenisC BEGIN */
				  $doc = new Document();  
/* ADD LINE DenisC END */
                  $doc->getFromDB($doc_i_data['documents_id']);

Line : ~236

            // replace img[src] and a[href] by cid:tag in html content

            foreach ($inline_docs as $docID => $tag) {
/* REMOVED LINES DenisC BEGIN */
/*               $current->fields['body_html'] = preg_replace([
                     '/src=["\'].*document\.send\.php\?docid='.$docID.'["\']/',
                     '/href=["\'].*document\.send\.php\?docid='.$docID.'["\']/',
                  ], [
                     "src=\"cid:$tag\"",
                     "href='".$CFG_GLPI['url_base']."/front/document.send.php?docid=$docID'",
                  ],
                  $current->fields['body_html']);

*/
/* REMOVED LINES DenisC END */
/* ADD LINE DenisC BEGIN */
				$current->fields['body_html'] = str_replace('src="/front/document.send.php?docid='.$docID.'"','src="cid:'.$tag.'"',$current->fields['body_html']);
				$current->fields['body_html'] = str_replace('href="/front/document.send.php?docid='.$docID.'"','href="'.$CFG_GLPI['url_base'].'/front/document.send.php?docid='.$docID.'"',$current->fields['body_html']);
/* ADD LINE DenisC END */
            }

            $mmail->Body   .= $current->fields['body_html'];
            $mmail->AltBody = $current->fields['body_text'];
         }

Hope it will help some of you.
Cheers
Denis/SoluNeXT