Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLPI 9.4.1.1 - simcard component broken (maybe other components as well) #5641

Closed
btry opened this issue Mar 20, 2019 · 1 comment
Closed
Labels

Comments

@btry
Copy link
Contributor

btry commented Mar 20, 2019

Hi

I noticed that the simcard component triggers a fatal error when we "instanciate" them then edit them to associate to an asset.

A clear and concise description of what the bug is.

Page(s) URL

If applicable, page(s) URL where the bug happens.

To reproduce

Steps to reproduce the behavior:

  1. go to components, simcards
  2. create a simcard template
  3. create an instance of the simcard
  4. click on Update to modify it
  5. See the fatal error in item_devices.class.php

Expected behavior

No fatal error

Logs

paste logs here
Find them in *-error.log files under glpi/files/_log/

( ! ) Fatal error: Uncaught Error: Class '' not found in /home/dethegeek/public_html/glpi-94/inc/item_devices.class.php on line 82
--
1 | 0.0002 | 396752 | {main}(  ) | .../item_devicesimcard.form.php:0
2 | 0.1500 | 2595304 | include( '/home/dethegeek/public_html/glpi-94/front/item_device.common.form.php' ) | .../item_devicesimcard.form.php:36
3 | 0.8275 | 8184752 | Item_DeviceSimcard->display(  ) | .../item_device.common.form.php:87
4 | 0.8399 | 8269368 | Item_DeviceSimcard->showNavigationHeader(  ) | .../commonglpi.class.php:996
5 | 0.8401 | 8269976 | Item_DeviceSimcard->getName(  ) | .../commonglpi.class.php:864
6 | 0.8401 | 8269976 | Item_DeviceSimcard->getRawName(  ) | .../commondbtm.class.php:3484

The instanciated simcard in Items_devicesimcards has an empty string in the column itemtype.

If I manually set it to Computer for example, the fatal error vanishes. The involved code is related to a commit done 29 days ago.

Screenshots

If applicable, add screenshots to help explain your problem.
image

paste here
@cconard96
Copy link
Contributor

@btry Could you test the fix in #5647?

ettalhi pushed a commit to ettalhi/glpi that referenced this issue Aug 26, 2019
ettalhi pushed a commit to ettalhi/glpi that referenced this issue Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants