Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show parent and recursive users is sub entities #632

Closed
nqb opened this issue Apr 29, 2016 · 10 comments
Closed

Show parent and recursive users is sub entities #632

nqb opened this issue Apr 29, 2016 · 10 comments
Assignees
Milestone

Comments

@nqb
Copy link
Contributor

nqb commented Apr 29, 2016

End-users are hidden in Administraton menu -> Users but could be find in Assets or Tickets.

Entity configuration :

               Organisation name (parent entity)
                    |
                    |
-------------------------------------------
|                   |                     |
|                   |                     |
Entity A (ex : IT)  Entity B           Entity C

All our end-users have self-service recursive profiles on parent entity. Technicians have technician profiles (no recursive) on entity which correspond to their department (ex : IT).

Steps to reproduce (with technician profile) :

  • Administration menu -> Users : only technician users visible
  • Assistance menu -> Create ticket -> Requester section : all end-users visible
  • Assets menu -> Computers -> Select computer -> Select User associated with computer : user visible

Expected behavior :

  • Administration menu -> Users : all end-users visible
@orthagh
Copy link
Contributor

orthagh commented May 27, 2016

Hello @nqb,

First sorry for the long delay of this answer (vacation and lot of works at my return).
The above commit should fix this issue and be part of the next release.
Thank you for your report.

Regards

@orthagh orthagh added the bug label May 27, 2016
orthagh added a commit that referenced this issue May 27, 2016
@orthagh orthagh added this to the 0.90.4 milestone May 27, 2016
@orthagh orthagh self-assigned this May 27, 2016
@yllen
Copy link
Collaborator

yllen commented May 27, 2016

This correction is not- correct.
I am in a sub-entity. In Administration > Users i must see only users of my sub-entity not all users having right to my sub-entity

@yllen yllen reopened this May 27, 2016
yllen added a commit that referenced this issue May 27, 2016
yllen added a commit that referenced this issue May 27, 2016
@orthagh
Copy link
Contributor

orthagh commented May 27, 2016

I strongly disagree with your answer (and the revert...)

In all other place, you can view theses users (in read-only), you can access their form (by direct link on the id or with navigation from an asset) but you couldn't list them, it's strange.

If you want to see all users of a particular entity, you should use search engine to do that, not the current active entity.

All others parts of glpi work with this behavior, you see in the list, current entity and recursive.

Why that difference on users ?

@yllen
Copy link
Collaborator

yllen commented May 27, 2016

This case is only for commandLine.
With your modification, you can update the user even he is in a parent entity

@nqb
Copy link
Contributor Author

nqb commented May 30, 2016

@yllen,

Could you explain your last comment ? I'm not sure to understand.

I agree with @orthagh point of view. Another behavoir which is strange :

  • In entity B, create a ticket as technician with end-user requester (self-service recursive profile on parent entity). Below name of requester, you see number of tickets with "Processing" status.
  • Click on link "Processing : X" . Search shows only tickets opened in entity B but "Processing : X" seems to count tickets opened in all entities.

@orthagh
Copy link
Contributor

orthagh commented May 30, 2016

@nqb, we had a phone call with yllen and she explains me the issue with the list of user.
I finally agree with her on the issue, we need more to resolve this.

The case is the list of user doesn't proper check rights and entities with bulk update.
I opened the above pull request with an additionnal fix to address this case.
We need to tests performance with this fix, but i think it will be good

For your aditionnal "strange behavior", could you open a dedicated issue to keep changelog clean, please ?

@nqb
Copy link
Contributor Author

nqb commented May 31, 2016

Ok. Thanks for you return.

@orthagh
Copy link
Contributor

orthagh commented Jun 8, 2016

PR merged in current master

@nqb
Copy link
Contributor Author

nqb commented Jul 25, 2016

Hello,

In 0.90.4, I don't see end-users when I go in Administration -> Users with a technician profile.

@orthagh orthagh reopened this Jul 25, 2016
@orthagh orthagh modified the milestones: 9.1, 0.90.4 Jul 25, 2016
@orthagh orthagh added enhancement and removed bug labels Jul 25, 2016
@orthagh orthagh changed the title [0.90.2] : Invisible end-users in Administration -> Users Show parent and recursive users is sub entities Jul 25, 2016
@orthagh
Copy link
Contributor

orthagh commented Jul 25, 2016

As this change is in fact a feature (and not a bug), the shipping will be for next major version (9.1) planned for mid september and not in bugfixes versions (0.90.x).

I missed to change the milestone and tags in this issue, it's now fixed

@orthagh orthagh closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants