Bug in dropdown translation

[yllen]

http://forum.glpi-project.org/viewtopic.php?id=150158

Introduce by 1f0fcdc#diff-a801c52129f44d50ab6d1db9f049c4b7

Dropdown list is never translated (because only use by super-admin).
Only dropdown in item is translated

[tomolimo]

Could it be reverted?
Or should I commit a revert?

[tomolimo]

Oups, sorry you've done it already, didn't you?

[yllen]

Yes i do the revert and now all is OK: list of dropdown is not translated but item in a dropdown is translated in an object (tested with many objects like statuses, itil categories...).
It's OK for you too?

[tomolimo]

OK for not doing the translation, I agree with you that when editing master data, we can edit them in default language.

[yllen]

OK i do the same in master branch

[yllen]

OK for you in master too?

[tomolimo]

I've no time to test, but I trust yours, so it's ok for me

[orthagh]

tests ok for me, i close.

[trasher]

Sounds like there is still an issue in current 9.1/bugfixes and master branch, apparently due to some changes in a984704.

Adding a status using dropdowns is working fine, but displaying the list produces the following error:

  *** MySQL query error:
  SQL: SELECT \'glpi\' AS currentuser,
                        `glpi_states`.`entities_id`, `glpi_states`.`is_recursive`,  `glpi_states`.`completename` AS `ITEM_0`,
                        `glpi_states`.`id` AS `ITEM_0_id`,
                        GROUP_CONCAT(DISTINCT CONCAT(IFNULL(IFNULL(`glpi_states_trans`.`value`,\'__NULL__\') , \'__NULL__\'),
                                                          \'$#$\',`glpi_states`.`id`)
                                          SEPARATOR \'$$##$$\')
                                  AS `ITEM_0_trans`, 
                        `glpi_entities`.`completename` AS `ITEM_1`,  `glpi_states`.`id` AS id  FROM `glpi_states`LEFT JOIN `glpi_entities` 
                                          ON (`glpi_states`.`entities_id` = `glpi_entities`.`id`
                                              ) WHERE   (  1 )  ORDER BY ITEM_0 ASC  LIMIT 0, 20
  Error: Unknown column 'glpi_states_trans.value' in 'field list'
  Backtrace :
  inc/search.class.php:921                           
  inc/search.class.php:97                            Search::constructDatas()
  inc/search.class.php:80                            Search::showList()
  front/dropdown.common.php:52                       Search::show()
  front/state.php:41                                 include()

There is no table named glpi_states_trans (in facts, there is no table named *_trans at all in the whole database).

As a quick fix, I've done:

 % git diff inc/search.class.php 
diff --git a/inc/search.class.php b/inc/search.class.php
index 6e759e1..7abf925 100644
--- a/inc/search.class.php
+++ b/inc/search.class.php
@@ -2533,12 +2533,12 @@ class Search {
                            $ADDITONALFIELDS";
                }
                $TRANS = '';
-               if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
+               /*if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
                    $TRANS = "GROUP_CONCAT(DISTINCT CONCAT(IFNULL($tocomputetrans, '".self::NULLVALUE."'),
                                                           '".self::SHORTSEP."',$tocomputeid)
                                           SEPARATOR '".self::LONGSEP."')
                                   AS `".$NAME."_".$num."_trans`, ";
-               }
+               }*/
                return " $tocompute AS `".$NAME."_$num`,
                         `$table$addtable`.`id` AS `".$NAME."_".$num."_id`,
                         $TRANS
@@ -2553,12 +2553,12 @@ class Search {
                   || isset($searchopt[$ID]["computationgroupby"])
                      && $searchopt[$ID]["computationgroupby"]))) { // Not specific computation
          $TRANS = '';
-         if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
+         /*if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
             $TRANS = "GROUP_CONCAT(DISTINCT CONCAT(IFNULL($tocomputetrans, '".self::NULLVALUE."'),
                                                    '".self::SHORTSEP."',$tocomputeid) SEPARATOR '".self::LONGSEP."')
                                   AS `".$NAME."_".$num."_trans`, ";
 
-         }
+         }*/
          return " GROUP_CONCAT(DISTINCT CONCAT(IFNULL($tocompute, '".self::NULLVALUE."'),
                                                '".self::SHORTSEP."',$tocomputeid) SEPARATOR '".self::LONGSEP."')
                               AS `".$NAME."_$num`,
@@ -2566,10 +2566,10 @@ class Search {
                   $ADDITONALFIELDS";
       }
       $TRANS = '';
-      if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
+      /*if (Session::haveTranslations(getItemTypeForTable($table), $field)) {
          $TRANS = $tocomputetrans." AS `".$NAME."_".$num."_trans`, ";
 
-      }
+      }*/
       return "$tocompute AS `".$NAME."_$num`, $TRANS $ADDITONALFIELDS";
    }

This is maybe not the way to go, but doing this, I can now see my statuses list and translate them. I'm pretty unsure what should be done here.

[trasher]

Still working on this one... The _trans stuff is just an alias added into a left join in the search class; displaying item list that permit to display translated dropdown values.
So maybe a solution would be to add also the join when coming from dropdown values list, do not know yet if this is possible.

[trasher]

A fix proposal:
trasher@ee2d9d9

[trasher]

The proposed solution add the missing query parts; retrieve translated value from DB, but this is not used (in administration, listed values should be what is exactly stored in database).

A better solution would be not to translate at all ; but as soon as we've got a datatype => 'itemlink' for something translated, the translation query will be played.

I'm not able to understand in which case the original code should be used; and so if the proposal breaks something or not.

I give up.

[trasher]

Saying that... I had an idea and I think I've finally find a fix...

[orthagh]

Checked and merged