Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing self service ticket form defaults #12473

Merged
merged 4 commits into from Sep 2, 2022
Merged

Fix missing self service ticket form defaults #12473

merged 4 commits into from Sep 2, 2022

Conversation

cconard96
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12427

When a ticket template is used in the self-service ticket creation form, multiple options are not set properly from the default values.
This PR fixes that and also changes how the entities_id is referenced within the template to match the regular ITIL Object form.

@cconard96 cconard96 added this to the 10.0.3 milestone Aug 23, 2022
@cconard96 cconard96 requested a review from btry August 23, 2022 18:50
@cconard96 cconard96 linked an issue Aug 23, 2022 that may be closed by this pull request
GLPI 10.0 dev: php warnings when impersonating post-only #12427
Closed
2 tasks
@trasher trasher requested a review from orthagh August 24, 2022 04:48
orthagh
orthagh reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say on the entity part.
But for the default value part, maybe we can factorize this part in a dedicated method.
We have the same code repeated in all showFormXXX methods (Commonitilobjet::showForm, same for Ticket and now the helpdesk form)

@trasher trasher requested a review from orthagh August 29, 2022 11:58
@orthagh
Copy link
Contributor

orthagh commented Aug 29, 2022

the @cedric-anne opinion should be better before merge.
Seems ok when reading the changes, but i may miss something

@cedric-anne cedric-anne removed this from the 10.0.3 milestone Sep 2, 2022
@cedric-anne cedric-anne merged commit 6f6e885 into glpi-project:10.0/bugfixes Sep 2, 2022
@cedric-anne cedric-anne mentioned this pull request Sep 5, 2022
Merged
@cconard96 cconard96 mentioned this pull request Sep 12, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@orthagh orthagh orthagh approved these changes

@btry btry btry approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLPI 10.0 dev: php warnings when impersonating post-only
5 participants
@cconard96 @orthagh @trasher @btry @cedric-anne