Add os installation date #12893
Merged
Add os installation date #12893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Oct 6, 2022
g-bougard
approved these changes
Oct 6, 2022
trasher
approved these changes
Oct 7, 2022
cedric-anne
reviewed
Oct 7, 2022
| @@ -47,3 +47,6 @@ | |||
|
|
|||
| //new right value for locked_field (previously based on config UPDATE) | |||
| $migration->addRight('locked_field', CREATE | PURGE, ['config' => UPDATE]); | |||
|
|
|||
| //add date_install | |||
| $migration->addField(getTableForItemType(Item_OperatingSystem::class), 'install_date', 'date'); | |||
There was a problem hiding this comment.
getTableForItemType(Item_OperatingSystem::class) should be replaced by glpi_items_operatingsystems
| 'table' => 'glpi_items_operatingsystems', | ||
| 'field' => 'install_date', | ||
| 'name' => __('Installation date'), | ||
| 'datatype' => 'string', |
There was a problem hiding this comment.
datatype should probably be datetime
|
|
||
| {{ fields.htmlField( | ||
| 'install_date', | ||
| item.fields['install_date'], |
There was a problem hiding this comment.
Maybe |formatted_datetime filter should be added here, to make the datetime formatted according to user preferences.
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add os installation date from inventory