Allow PHP 8.2

[cedric-anne]

Q	A
Bug fix?	yes/no
New feature?	yes/no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#13758

Allowed PHP version has been updated in inc/define.php but not in index.php.

glpi/inc/define.php

Lines 51 to 52 in 0046d6d

	define('GLPI_MIN_PHP', '7.4.0'); // Must also be changed in top of index.php
	define('GLPI_MAX_PHP', '8.3.0'); // (Exclusive) Must also be changed in top of index.php

We did not detect it earlier as we are probably all using a pre-release version (that is considered as less than 8.2.0). Using -dev suffixes in comparison will prevent PHP 8.3 pre-releases to be accepted. Test will be similar to the test done in requirements checking:

glpi/src/System/Requirement/PhpVersion.php

Lines 79 to 84 in 0046d6d

	$this->validated = version_compare(PHP_VERSION, sprintf('%s-dev', $min_version), '>=')
	&& version_compare(PHP_VERSION, sprintf('%s-dev', $max_version), '<');
	$this->validation_messages[] = $this->validated
	? sprintf(__('PHP version (%s) is supported.'), PHP_VERSION)
	: sprintf(__('PHP version must be between %s and %s (exclusive).'), $min_version, $max_version);

Note that checks has been refactore in main to simplify versions declaration: #13260

[trasher]

why those -dev?

[trasher]

we should have same versions ins both files

[cedric-anne]

-dev suffixes are added during comparison in requirement check, see

glpi/src/System/Requirement/PhpVersion.php

Lines 79 to 84 in 0046d6d

	$this->validated = version_compare(PHP_VERSION, sprintf('%s-dev', $min_version), '>=')
	&& version_compare(PHP_VERSION, sprintf('%s-dev', $max_version), '<');
	$this->validation_messages[] = $this->validated
	? sprintf(__('PHP version (%s) is supported.'), PHP_VERSION)
	: sprintf(__('PHP version must be between %s and %s (exclusive).'), $min_version, $max_version);

So I added -dev suffix here to do the exact same comparison.

[trasher]

we should have same versions ins both files

That does not explain this difference