Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Massive actions) add status check before adding tasks/followups #14037

Conversation

tsadock
Copy link
Contributor

@tsadock tsadock commented Feb 8, 2023

Rights uniformisation for twig and massive actions to add tasks and followups

The timeline buttons at the bottom of Ticket or Change are displayed at this condition :
{% if item.isNotSolved() and default_action_data != false %} (components/itilobjects/footer.html.twig)
==> Only displayed if item is not solved

If the specified item is solved, no possibility to add a new followup by this way.
But, it is always possible via massive actions because the condition is :
if (in_array($item->fields['status'], $item->getClosedStatusArray())){

This PR uniformise the condition : allow to add followup or task only if item is not closed and is not solved.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no

@cedric-anne cedric-anne added this to the 10.0.7 milestone Feb 8, 2023
@cedric-anne cedric-anne added the bug label Feb 8, 2023
@cedric-anne cedric-anne changed the title fix(Massive actions) rights uniformisation for twig and massive actio… fix(Massive actions) add status check before adding tasks/followups Feb 8, 2023
@trasher trasher merged commit 2519e73 into glpi-project:10.0/bugfixes Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants