Enhance LDAP errors handling #14561
Merged
Enhance LDAP errors handling #14561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As draft for now, for first feedbacks. |
orthagh
approved these changes
Apr 19, 2023
cedric-anne
reviewed
Apr 19, 2023
There was a problem hiding this comment.
👍
This is really a great move here. We should always use defensive code when dealing with a remote service, especially when it involves dynamic data entered by the end user.
I think it could be a good idea to add tests that validates that all these failing cases are producing helpful messages, at least with openldap.
trasher
commented
Apr 19, 2023
trasher
commented
Apr 19, 2023
cedric-anne
reviewed
Apr 19, 2023
cedric-anne
reviewed
Apr 19, 2023
cedric-anne
approved these changes
Apr 19, 2023
cedric-anne
changed the title
This was referenced Apr 20, 2023
cedric-anne
force-pushed
the
fix/handle-ldap-errors
branch
from
179d37a
to
fea87c1
Compare
trasher
force-pushed
the
fix/handle-ldap-errors
branch
from
fea87c1
to
4010301
Compare
Silent error in status checker Properly handle non existing group Deprecate dead 'clean' parameter Handle LDAP_NO_SUCH_OBJECT error response from LDAP Fix return types; limit encapsulation, simplify code Deprecated useless param Handle errors on `ldap_parse_result`
trasher
force-pushed
the
fix/handle-ldap-errors
branch
from
4010301
to
0a5a624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to replace #14356