Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent unsupported operand types int + string #16496

Merged
merged 10 commits into from
Feb 6, 2024
Merged

fix: prevent unsupported operand types int + string #16496

merged 10 commits into from
Feb 6, 2024

Conversation

Rom1-B
Copy link
Contributor

@Rom1-B Rom1-B commented Feb 1, 2024 •
edited by trasher
Loading

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #16466 #16498 
glpiphplog.CRITICAL: *** Uncaught Exception TypeError: Unsupported operand types: int + string in .../src/LevelAgreement.php at line 855
Backtrace :
src/Ticket.php:449 LevelAgreement->computeDate()
src/Ticket.php:1428 Ticket->getDatasToAddSLA()
src/Ticket.php:2027 Ticket->slaAffect()
src/CommonDBTM.php:1297 Ticket->prepareInputForAdd()
front/ticket.form.php:80 CommonDBTM->add()

@cedric-anne cedric-anne mentioned this pull request Feb 1, 2024
Closed
2 tasks
@cedric-anne cedric-anne linked an issue Feb 1, 2024 that may be closed by this pull request
Blank screen when creating a new change #16466
Closed
2 tasks
trasher
trasher reviewed Feb 1, 2024
View reviewed changes
src/Ticket.php Outdated Show resolved Hide resolved
@Rom1-B Rom1-B requested a review from trasher February 2, 2024 07:19
cconard96
cconard96 suggested changes Feb 3, 2024
View reviewed changes
src/Ticket.php Outdated Show resolved Hide resolved
src/Ticket.php Outdated Show resolved Hide resolved
cedric-anne
cedric-anne requested changes Feb 5, 2024
View reviewed changes
src/Ticket.php Outdated Show resolved Hide resolved
src/Ticket.php Outdated Show resolved Hide resolved
Rom1-B and others added 2 commits February 5, 2024 08:19
@Rom1-B @cedric-anne @cconard96
Apply suggestions from code review
8265fc1 
Co-authored-by: Cédric Anne <cedric.anne@gmail.com>
Co-authored-by: Curtis Conard <cconard96@gmail.com>
@Rom1-B
cast in computeDate
f24e082
trasher
trasher reviewed Feb 5, 2024
View reviewed changes
src/CommonITILObject.php Outdated Show resolved Hide resolved
trasher
trasher reviewed Feb 5, 2024
View reviewed changes
src/Ticket.php Outdated Show resolved Hide resolved
cedric-anne
cedric-anne reviewed Feb 5, 2024
View reviewed changes
src/Ticket.php Outdated Show resolved Hide resolved
src/Ticket.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne mentioned this pull request Feb 5, 2024
Closed
2 tasks
@Gor3pig
Copy link

Gor3pig commented Feb 5, 2024

I've just tested it in production by applying the latest fix, it works well. Thanks a lot 👍

@cedric-anne cedric-anne merged commit b156f9b into glpi-project:10.0/bugfixes Feb 6, 2024
13 checks passed
@Rom1-B Rom1-B deleted the issue_16466 branch February 6, 2024 08:00
@cconard96 cconard96 mentioned this pull request Feb 8, 2024
Closed
2 tasks
This was referenced Feb 19, 2024
Closed
Closed
@cedric-anne cedric-anne mentioned this pull request Mar 7, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconard96 cconard96 cconard96 requested changes

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@orthagh orthagh Awaiting requested review from orthagh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank screen when creating a new change
5 participants
@Rom1-B @Gor3pig @trasher @cconard96 @cedric-anne