SLM Twig UI #16911
Merged
SLM Twig UI #16911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconard96
force-pushed
the
ui/slm
branch
2 times, most recently
from
70e86ac
to
e3a65f2
Compare
orthagh
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Some issues may be in the main branch directly. I didn't have the time to investigate more.
- form for adding an escalation level seems to lose the relation with the parent SLA/OLA
- I got an incoherence between the number of tickets counted in the tab (32) vs the tab content (no data).
- general advice: if you find a number dropdown without any special option (like the one for maximum time), replace it with a simple
input[type=number]
Regarding the UI/UX, nothing to say
Fixed
Doesn't seem related. This tab also triggers a deprecation warning. It looks like the way this tab is handled was changed a few times in the last year or two. |
orthagh
approved these changes
Apr 16, 2024
cedric-anne
reviewed
Apr 16, 2024
cedric-anne
approved these changes
Apr 17, 2024
trasher
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #16910.
UX change for escalation levels list. I'm not sure if it changed with a previous Twig PR since it reuses UI code from rules, or was always like this, but the escalation levels list looked too crowded and wasn't easy for me (someone who doesn't use service levels) to understand what was going on.
Before (Without any criteria or actions):
After (With a criteria and action):
The change makes the list cleaner but also means that the criteria and actions cannot be added/changed from the escalation level list anymore. You have to click the escalation level link to open its form.