Rework of LDAP user import UI #17214
Conversation
cconard96
changed the title
|
Sorting of results is not present in the new UI. The old behavior was completely broken and would clear the results (#14865). The implementation also only would have changed the order of the results returned by the LDAP server. It didn't actually sort by any field client-side or server-side. When researching server-side sorting, I found that it is an optional implementation and Microsoft AD doesn't seem to support it. For client-side sorting, it would still only sort the results returned which may only be a partial result depending on LDAP settings. So, there doesn't seem to be a good way to support sorting here. |
Fixed |
There was a problem hiding this comment.
As I've not any local setup to test, and tha'ts not a part I know well; I do not know if changes are OK.
I'm "afraid" changes from $_SESSSION to $_REQUEST (which we should avoid, but that's not the point) would really break things - for example.
This seems a bit huge change for a "UI rework".
Based on #16951. Clean up/twig migration for the LDAP user import UI.
Before:
After:
Goal is to remove the use of temporary data in the session if possible and use less page reloads. Currently with this PR, switching between "expert" and "simple" views is seamless now.