Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a local define file for a clean override of some options #1727

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Jan 30, 2017

Just create a config/local_define.php; add overdidable
defines declarations in it (GLPI_DEMO_MODE and GLPI_USE_CSRF_CHECK
for now)

Ensure based_config is always loaded before define file

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

Just create a `config/local_define.php`; add overdidable
defines declarations in it (GLPI_DEMO_MODE and GLPI_USE_CSRF_CHECK
for now)

Ensure based_config is always loaded before define file
Copy link
Contributor

@tomolimo tomolimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@trasher
Copy link
Contributor Author

trasher commented Jan 31, 2017

Thanks you both for the review :)

I've tagged "need doc"; but it should reach user documentation but we do not get up to date doc right now. I've opened a ticket for that (see glpi-project/doc#9).

@trasher trasher merged commit 010d6f5 into glpi-project:master Jan 31, 2017
@trasher trasher deleted the local_config branch January 31, 2017 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants