Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop methods that should have been deprecated and aht should no be us… #1901

Merged
merged 5 commits into from
Mar 10, 2017

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Mar 3, 2017

…ed at all now

Q A
Bug fix? no
New feature? no
BC breaks? no (not in the core)
Deprecations? yes (kind of)
Tests pass? yes

This may break plugins; but they should have been updated. Without methods, users will raise an real error (instead of an empty page without logs).

@trasher trasher added this to the 9.2 milestone Mar 3, 2017
@trasher
Copy link
Contributor Author

trasher commented Mar 6, 2017

I'm not going to merge that one right now; because some plugins still use some of those methods... As far a I can see (greppin' from my plugins dir):

  • formcreator,
  • fusioninventory-for-glpi (verified :/),
  • simcard,
  • geninventorynumber.

I've njot yet checked if they really use the dropped methods for the core or if they redefine their own.

@orthagh
Copy link
Contributor

orthagh commented Mar 6, 2017

  • accounts
  • racks
  • monitoring
  • order (some commented)

@trasher
Copy link
Contributor Author

trasher commented Mar 6, 2017

I've reported the issue on every identified plugin.

@trasher trasher merged commit 6a094c0 into glpi-project:master Mar 10, 2017
@trasher trasher deleted the clean-old-methods branch March 10, 2017 14:52
@yllen
Copy link
Collaborator

yllen commented Mar 10, 2017

If you delete functions in the cofre, don't forget to add them in wiki of the plugins, like https://forge.glpi-project.org/projects/plugins/wiki/Fr_Plugin083to084

@yllen
Copy link
Collaborator

yllen commented Mar 10, 2017

You can't indicate a function deprecated if this function is already used in the core.
You must change all calls before (ex. function next())

@wawax
Copy link

wawax commented Mar 10, 2017

Hi @yllen ,

We're currently finishing a brand new, complete, developer documentation at http://glpi-developer-documentation.readthedocs.io/en/master/ .
Adding a deprecated functions page is, IMHO, the best place to do it.

Regards

@trasher
Copy link
Contributor Author

trasher commented Mar 13, 2017

I'll change next() calls to reflect the state; good catch.

As for methods depreciation; they're actually all referenced in the CHANGELOG.md file; we'll add them in a more complete documentation later, I'm missing time ;)

@remicollet
Copy link
Contributor

You must change all calls before (ex. function next())

See pr #1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants