Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent task list on central to differs from real search #3026

Merged
merged 1 commit into from Oct 24, 2017

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Oct 20, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes

Also, i add a new static method in CommonITILObject to prevent code duplication

For the original issue:

  • on central (bottom of the page)
    image

  • ticket list
    image

@orthagh orthagh added this to the 9.2.1 milestone Oct 20, 2017
@orthagh orthagh requested a review from trasher October 20, 2017 15:20
*
* @since version 9.2.1
*
* @return an array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax is @return type description ;)

trasher
trasher previously approved these changes Oct 23, 2017
@trasher trasher dismissed their stale review October 23, 2017 06:18

UT are failing

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

@orthagh
Copy link
Contributor Author

orthagh commented Oct 23, 2017

tests fixed, docblock fixed, and rebased done

@trasher trasher merged commit 16948a1 into glpi-project:9.2/bugfixes Oct 24, 2017
@orthagh orthagh mentioned this pull request Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants