Improve checks on read files directory #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
force-pushed
the
improve-checkfiles
branch
from
86df33e
to
4efc5cf
Compare
remicollet
approved these changes
Mar 1, 2018
| if (isset($_SERVER['HTTPS'])) { | ||
| $protocol = 'https'; | ||
| } | ||
| $uri = $protocol . '://' . $_SERVER['SERVER_NAME'] . $CFG_GLPI['root_doc']; |
There was a problem hiding this comment.
indeed using server_name may be required for vhost/ssl, but mays be different from the client side (where is it retrieved) and from the server side.... btw no perfect solution... will need a JS check from the client
There was a problem hiding this comment.
Yes, this is not perfect; but maybe a bit better than just test localhost without https ;)
| } else { | ||
| echo "<td><img src='".$CFG_GLPI['root_doc']."/pics/warning_min.png'>". | ||
| "<p class='red'>".__('Web access to the files directory, should not be allowed')."<br/>". | ||
| __('Automatic checks cannot be done; please review .htaccess file and the web server configuration.')."</p></td></tr>"; | ||
| } |
There was a problem hiding this comment.
IIRC, there is tons of false positive... btw, ok to raise admin attention
There was a problem hiding this comment.
I totaly agree... But this will permit to get rid of "files directory is insecure". We all agree that the way to go is to store files outside the webroot ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
1- display a warning when checks cannot be done. User is aware of potential issue; it's up to him.
2- try to guess host (I almost never user localhost myself; and I guess most of the time called URI will not be localhost only).