Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bottom positioning in split layout #4722

Merged
merged 1 commit into from Oct 1, 2018
Merged

fix bottom positioning in split layout #4722

merged 1 commit into from Oct 1, 2018

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Oct 1, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes

in split layout:

  • 33px for left form corresponds to the footer height on bare glpi (50px is with fusioninventory additional footer, not our problem)
  • 50px for right (with a calculated value instead of a raw percent) is the height of previous element (.navigationheader), in fact 49px but i kept 1px for having a soft border.

Results

before

image

after

image

@orthagh orthagh added this to the 9.3.2 milestone Oct 1, 2018
@trasher trasher merged commit bdd0c5c into glpi-project:9.3/bugfixes Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
need_cherrypick
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orthagh @trasher @cedric-anne