Report check tests, drop very old TU directory #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
requested changes
Oct 18, 2018
trasher
force-pushed
the
drop-old-tests
branch
from
be422f2
to
bf61954
Compare
orthagh
reviewed
Oct 18, 2018
trasher
force-pushed
the
drop-old-tests
branch
from
bf61954
to
3159e8d
Compare
trasher
force-pushed
the
drop-old-tests
branch
from
3159e8d
to
8823bf3
Compare
trasher
force-pushed
the
drop-old-tests
branch
from
8823bf3
to
10e1e0d
Compare
trasher
force-pushed
the
drop-old-tests
branch
from
f1a27c2
to
5858535
Compare
|
This one targets next major because change on CommonDBRelation may have unpredictable impacts, and this needs to be tested :/ |
cedric-anne
reviewed
Oct 29, 2018
tests/functionnal/CommonDBTM.php
Outdated
|
|
||
| $input = [ | ||
| 'contacts_id' => $idc[3], // Child 2 | ||
| 'suppliers_id' => $ids[3] // Child 3 |
There was a problem hiding this comment.
Comment is wrong : should be $ids[3] // Child 2 instead of $ids[3] // Child 3.
cedric-anne
reviewed
Oct 29, 2018
tests/functionnal/CommonDBTM.php
Outdated
| $input=['entities_id' => -1]; | ||
| $this->boolean($entity->can(-1, CREATE, $input))->isFalse("Fail: can create entity in not existing entity"); | ||
|
|
||
| $this->boolean(\Session::changeActiveEntities('all'))->isTrue(); |
There was a problem hiding this comment.
Looks like there is a lot of duplication in tests. From this line to line 750, only tests on 99999 are not duplicated (see lines 707 to 721).
There was a problem hiding this comment.
Lines from 752 to 761 are duplications too.
Fix entities tests Drop duplicated lines Wrong comment
trasher
force-pushed
the
drop-old-tests
branch
from
4a18e82
to
67783bc
Compare
cedric-anne
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal is just to drop
tools/phpunitdirectory (very first unit tests).I've tried to keep and migrate
phpunit/Framework/CommonDBTM/CanCheck.php; some results are not the same.See commented lines in
tests/functionnal/CommonDBTM.phpat lines 543-558, 665, 671-673 and 680I cannot say if original tests were wrong, or if code/logic has changed, or...