Add lightbox to timeline images with PhotoSwipe

[cconard96]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#3139

closes #3139

Currently uses single-image galleries in timelines of ITIL Objects. Looking into possibly grouping images and documents in the timeline, but seems like a big task.
UserEcho for document groups idea

[cedric-anne]

Hi @cconard96 ,

I rebased your branch on 9.5/bugfixes, and add some commits to:

• fetch PhotoSwipe using npm (instead of pushing lib files to our repository),
• fix rendering of thumbnail (I put back exisiting styles),
• clean some code that seems useless.

I did not reviewed all code yet, but I will do it in order to put this feature into 9.5/bugfixes (if other core devs are OK for this).

Regards

[cedric-anne]

OK for me.

I added some commits, so do not hesitate to tell me if I have done something wrong.

[cconard96]

Good for me with one minor change. The figures were incorrectly sized so clicking to the right of the thumbnail would still trigger the lightbox.

[orthagh]

One issue, it seems to be ok only for attached documents.
For inline pictures (in followups/task/etc), they still open in a separate tab.

It's disturbing on my side, because we have different behaviors for same objets (but with different contexts)

[cconard96]

I can't get the images to open at all when embedded in followups or tasks. It is just a static img element. Am I missing something? Adding as a document or attachment (under a followup or task) seems to work OK.

[cedric-anne]

One issue, it seems to be ok only for attached documents.
For inline pictures (in followups/task/etc), they still open in a separate tab.

It's disturbing on my side, because we have different behaviors for same objets (but with different contexts)

I can't get the images to open at all when embedded in followups or tasks. It is just a static img element. Am I missing something? Adding as a document or attachment (under a followup or task) seems to work OK.

I added a commit to handle this.

PR has changed

[trasher]

OK for me :)