Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill for String.prototype.normalize() #5416

Merged
merged 5 commits into from
Feb 20, 2019
Merged

Polyfill for String.prototype.normalize() #5416

merged 5 commits into from
Feb 20, 2019

Conversation

AdrienClairembault
Copy link
Contributor

@AdrienClairembault AdrienClairembault commented Feb 20, 2019 •
edited
Loading

Compatibility fix for IE (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize#Browser_compatibility).

Polyfill used : https://github.com/walling/unorm

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Internal ref 16088

cedric-anne
cedric-anne reviewed Feb 20, 2019
View reviewed changes
js/common.js Outdated Show resolved Hide resolved
trasher
trasher approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cannot test)

@cedric-anne
Copy link
Member

https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ :D

@cedric-anne cedric-anne added this to the 9.4.1 milestone Feb 20, 2019
@trasher trasher merged commit 1d42efb into glpi-project:9.4/bugfixes Feb 20, 2019
@cedric-anne cedric-anne mentioned this pull request Feb 20, 2019
Merged
ettalhi pushed a commit to ettalhi/glpi that referenced this pull request Aug 26, 2019
@AdrienClairembault
Polyfill for String.prototype.normalize() (glpi-project#5416)
f81ea79
@AdrienClairembault AdrienClairembault deleted the normalize-ie-unorm branch October 4, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh left review comments

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
9.4.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdrienClairembault @cedric-anne @trasher @orthagh