Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JOINs in delete and update queries building; fixes #5478 #5482

Merged

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #5478

In MySQL, JOINS are part of table_references element of query (see https://dev.mysql.com/doc/refman/5.6/en/join.html), so they must be appended just next to the main table name.
SELECT * FROM a JOIN b ...
DELETE FROM a JOIN b ...
UPDATE a JOIN b ...

@trasher trasher merged commit 4c9d46c into glpi-project:9.4/bugfixes Feb 28, 2019
@cedric-anne cedric-anne deleted the 9.4/fix-update-delete-joins branch February 28, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants