Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved searches should recall displayed column list. #5885

Closed

Conversation

FVallieres
Copy link

Saved searches should recall displayed column list

We also want to see the same list of columns printed into PDF format
for example.

Currently saved searches dont show the original list of columns that has been the first time the search has been created. the same error occurs when exporting a search result; what is exported does not match what is seen by the user !

This PR is linked to the discussed idea in the following link :
https://glpi.userecho.com/communities/1/topics/1015-saved-searches-dont-recall-the-list-of-displayed-columns

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets

@ettalhi
Copy link

ettalhi commented May 28, 2019

@trasher , @loicbenoit, @cedric-anne :
Can we have a comment or feedback about this PR please.

@cedric-anne
Copy link
Member

Hi,

I am not in favor of applying this behaviour to all saved searches. I propose to add a new option to saved searches form in order to give ability to define if displayed columns have to be restored or not when search is reloaded.
I also think that you should not list all columns in search URL but maybe just save the list of displayed columns into saved search object in order to be able to easilly load this list.

However, as you are going to change search engine, we will require all of this to be added to test suite in order to be sure that everything still works as expected.

Regards

@cedric-anne
Copy link
Member

Hi,

I close this PR as it looks stale. Feel free to reopen if you have time to work on it.

Regards

@cedric-anne cedric-anne closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants