New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cert and key for LDAPS #8748
Merged
trasher
merged 6 commits into
glpi-project:master
from
flegastelois:feature/ldaps_cert_and_key
Mar 19, 2021
Merged
feat: support cert and key for LDAPS #8748
trasher
merged 6 commits into
glpi-project:master
from
flegastelois:feature/ldaps_cert_and_key
Mar 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be interesting, to have a "Google Workspace" pre-configured schema (like "AD" or "Default") when we create a new ldap authentification server. https://support.google.com/a/answer/9188164?hl=en&ref_topic=9048334
|
flegastelois
force-pushed
the
feature/ldaps_cert_and_key
branch
from
March 5, 2021 08:50
318416a
to
9d78c95
Compare
trasher
force-pushed
the
feature/ldaps_cert_and_key
branch
from
March 18, 2021 09:09
b9655d7
to
10f7fb6
Compare
trasher
force-pushed
the
feature/ldaps_cert_and_key
branch
from
March 19, 2021 06:47
0d03174
to
9e6bad1
Compare
trasher
changed the title
[WIP] feat: support cert and key for LDAPS
feat: support cert and key for LDAPS
Mar 19, 2021
cedric-anne
reviewed
Mar 19, 2021
cedric-anne
approved these changes
Mar 19, 2021
orthagh
approved these changes
Mar 19, 2021
cedric-anne
reviewed
Mar 19, 2021
cedric-anne
reviewed
Mar 19, 2021
cedric-anne
reviewed
Mar 19, 2021
trasher
force-pushed
the
feature/ldaps_cert_and_key
branch
from
March 19, 2021 13:51
26f365d
to
6cdb99f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need 3 new column in "glpi_authldap":
These changes allow the LDAP authentication / import / directory synchronization to work with secure servers that require a certificate and a private key for connection: this explains the two added option fields (tls_certfile, tls_keyfile).
Although they are called "tls_", you must not enable TLS for the connection to work, which is why I have not conditioned their addition (ldap_set_option) to the boolean "use_tls".
Google Workspace for example:
https://support.google.com/a/answer/9190869?hl=en&ref_topic=9048334#zippy=%2Cldapsearch
In the case of using a certificate and its private key, "ldap_bind" must not be used, this explains the added option.
I can give you production ready "certificate / key" files to add in "GLPI_CONFIG_DIR/ldap/" directory.