Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown name escaping and autonaming from templates; fixes #8818 #9101

Merged
merged 1 commit into from Jun 15, 2021
Merged

Fix dropdown name escaping and autonaming from templates; fixes #8818 #9101

merged 1 commit into from Jun 15, 2021

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8818

@cedric-anne cedric-anne self-assigned this May 26, 2021
@cedric-anne cedric-anne mentioned this pull request Jun 3, 2021
Merged
@cedric-anne
Copy link
Member Author

strip_tags on name field was introduced to prevent XSS issue on items created from Kanaban. As this XSS issue has been fixed in another way by #9136, strip_tags on name field is not needed anymore.

@cedric-anne cedric-anne requested review from trasher and orthagh and removed request for trasher and orthagh June 15, 2021 09:41
@cedric-anne cedric-anne mentioned this pull request Jun 15, 2021
Closed
@cedric-anne cedric-anne merged commit 58c9a40 into glpi-project:9.5/bugfixes Jun 15, 2021
@cedric-anne cedric-anne deleted the 9.5/fix-autonaming branch June 15, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@orthagh orthagh orthagh approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

Assignees

@cedric-anne cedric-anne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cedric-anne @trasher @orthagh @stonebuzz