Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPStan level 0 checks #9827

Merged
merged 62 commits into from
Sep 13, 2022
Merged

Add PHPStan level 0 checks #9827

merged 62 commits into from
Sep 13, 2022

Conversation

cedric-anne
Copy link
Member

@cedric-anne cedric-anne commented Nov 3, 2021 •
edited

Q A
Bug fix? maybe
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

@cedric-anne cedric-anne self-assigned this Nov 3, 2021
@cedric-anne cedric-anne force-pushed the 10.0/phpstan-lvl-0 branch 2 times, most recently from 1f1c61c to b468a0e Compare December 9, 2021 10:11
@cedric-anne cedric-anne force-pushed the 10.0/phpstan-lvl-0 branch 2 times, most recently from 8944f34 to 4200936 Compare March 1, 2022 09:17
@cedric-anne cedric-anne changed the base branch from master to 10.0/bugfixes April 11, 2022 08:58
cconard96 added a commit to glpi-project/docdev that referenced this pull request May 29, 2022
@cconard96
Allow all PHPStan type definitions
5133ff3 
Rather than adding them individually like `class-string`, simply state that all PHPStan types can be used especially if we are going to be utilizing this tool in the future.
See: glpi-project/glpi#9827
@cconard96 cconard96 mentioned this pull request May 29, 2022
Merged
trasher pushed a commit to glpi-project/docdev that referenced this pull request May 30, 2022
@cconard96 @trasher
Allow all PHPStan type definitions
12f0592 
Rather than adding them individually like `class-string`, simply state that all PHPStan types can be used especially if we are going to be utilizing this tool in the future.
See: glpi-project/glpi#9827
@cedric-anne
Add PHPStan level 0 check
1733286
@cedric-anne
Fix: Method NotificationSettingConfig::update() should return bool bu…
dfd03a8 
…t return statement is missing.
@cedric-anne
Fix: Method Html::showDatesTimelineGraph() should return array but re…
9a0cb32 
…turn statement is missing.
@cedric-anne
Fix: Array has 2 duplicate keys with value 'multiple' ('multiple', 'm…
dbb1e7f 
…ultiple').
@cedric-anne
Fix: Access to an undefined property HTMLTableMain::$title.
3621071
@cedric-anne
Fix: Access to an undefined property HTMLTableGroup::$ordered_headers.
e9cdd93
@cedric-anne
Fix: Variable $subheader_name is undefined
147faf3
@cedric-anne
Fix: Access to an undefined property HTMLTableCell::$numberOfLines.
2aa6981
@cedric-anne
Fix: Access to an undefined property HTMLTableCell::$start.
1db7b5c
@cedric-anne
Fix: Call to function unset() contains undefined variable $name|$type…
c4c266f 
…|$cbbox|$cidinfo|$cw|$dw.
@cedric-anne
Fix: Method GLPIMailer::setLanguage() should return bool but return s…
079af88 
…tatement is missing.
@cedric-anne
Fix FieldUnicity display when there is no fields selected
64a6bdd
@cedric-anne
Fix: Method Glpi\Features\PlanningEvent::getAlreadyPlannedInformation…
75dc10d 
…() should return string but return statement is missing.
@cedric-anne
Fix: Call to an undefined static method PlanningExternalEventTemplate…
c796391 
…::getVisibilityCriteria().
@cedric-anne
Fix: Instantiated class CommonITILTask is abstract.
d1e9ab4
@cedric-anne
Fix: Undefined variable: $options
1102b16
@cedric-anne
Fix: Parameter #1 $position (int) of method DBmysqlIterator::seek() i…
d0fe585 
…s not contravariant with parameter #1 $offset (mixed) of method SeekableIterator::seek().
@cedric-anne
Fix: Call to an undefined static method static(CommonDBTM)::getDcBrea…
b468487 
…dcrumbSpecificValueToDisplay().
@cedric-anne
Fix: Access to an undefined property CommonDBTM::$itemtype.
5c7edfa
@cedric-anne
Fix: Result of method CommonDBTM::canGlobal() (void) is used.
a7dbae6
@cedric-anne
Fix: Result of method CommonDBTM::updateInDB() (void) is used.
eec7053
@cedric-anne
Fix: Call to an undefined method CommonDBTM::clone().
b99d6ed
@cedric-anne
Fix: Method CommonDBTM::restoreSavedValues() should return array but …
2e909d7 
…return statement is missing.
@cedric-anne
Fix: Method Certificate_Item::showForItem() should return bool but re…
4c12d0b 
…turn statement is missing.
@cedric-anne
Fix: Result of static method Contract::showCentral() (void) is used.
5fdc80f
@cedric-anne
Fix: Method Cartridge::uninstall() should return bool but return stat…
0a123f6 
…ement is missing.
@cedric-anne
Fix: Method AuthLDAP::ldapImportUserByServerId() should return array|…
3092d7f 
…bool but return statement is missing.
@cedric-anne
Fix: Unsafe usage of new static().
f1195d3
@cedric-anne
Fix: Function brotli_compress|brotli_uncompress not found.
81ac5be
@cedric-anne cedric-anne marked this pull request as ready for review September 12, 2022 19:11
trasher
trasher reviewed Sep 13, 2022
View reviewed changes
src/CronTask.php Outdated Show resolved Hide resolved
orthagh
orthagh approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some little things to fix, but ok with the pr

inc/based_config.php Outdated Show resolved Hide resolved
phpstan.neon Show resolved Hide resolved
cedric-anne
cedric-anne commented Sep 13, 2022
View reviewed changes
inc/based_config.php Outdated Show resolved Hide resolved
@cedric-anne cedric-anne merged commit 938a234 into glpi-project:10.0/bugfixes Sep 13, 2022
@cedric-anne cedric-anne deleted the 10.0/phpstan-lvl-0 branch September 13, 2022 10:31
@cedric-anne cedric-anne added this to the 10.0.3 milestone Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@orthagh orthagh orthagh approved these changes

@cconard96 cconard96 cconard96 approved these changes

Assignees

@cedric-anne cedric-anne

Labels
bug
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cedric-anne @trasher @orthagh @cconard96