Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: If image is not used in scatter layer, use an empty image. #324

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix: If image is not used in scatter layer, use an empty image. #324

merged 1 commit into from
Oct 11, 2022

Conversation

maartenbreddels
Copy link
Collaborator

@maartenbreddels
fix: if image is not used in scatter layer, use an empty image.
c80e3ef 
If we do not, bqplot-image-gl will create the default image data
(which is scalar data). This by default gives an error messages.

The alternative would be to allow the image data for the ImageGL
widget to be None.
@pllim pllim mentioned this pull request Oct 11, 2022
Open
@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Base: 89.24% // Head: 89.24% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c80e3ef) compared to base (8eea5b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          86       86           
  Lines        4286     4287    +1     
=======================================
+ Hits         3825     3826    +1     
  Misses        461      461
Impacted Files Coverage Δ
glue_jupyter/bqplot/scatter/layer_artist.py 99.43% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

astrofrog
astrofrog approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astrofrog astrofrog merged commit 2c1ccdd into glue-viz:main Oct 11, 2022
@pllim
Copy link
Contributor

pllim commented Oct 12, 2022

I think this got rid of the error. Thanks!

@dhomeier dhomeier changed the title fix: if image is not used in scatter layer, use an empty image. Fix: If image is not used in scatter layer, use an empty image. Oct 26, 2022
@dhomeier dhomeier added the bug Something isn't working label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

viewer.add_markers() has error on browser dev console
4 participants
@maartenbreddels @pllim @astrofrog @dhomeier