-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API to support echo>=0.6
and vispy=0.11
#373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
- Coverage 80.48% 80.10% -0.39%
==========================================
Files 50 50
Lines 3885 4016 +131
==========================================
+ Hits 3127 3217 +90
- Misses 758 799 +41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@astrofrog I got the local tests under macOS/Python 3.9 down to 4 failed, 33 passed with this, so would like to get #371 merged and rebase to check if all the teardown errors with linux/macos here are due to the Azure setup. |
a951cb5
to
78e0cc7
Compare
Not pretty, but disabling the broken tests from (•4, •5) got rid of the teardown errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fd235b6
to
1edb0ec
Compare
bf78c73
to
6916a6a
Compare
6916a6a
to
1502b14
Compare
@astrofrog some more issues came up after rebasing:
They appeared actually already in #371, just missed them among the other failures. Also, the last Azure runs for this PR showed a bunch of exceptions/warnings like
however still returned as "passed". I have skipped those tests on win32, but am now well into |
@astrofrog I was not able to restart the windows runs here to check if those problems are still present, but I think this should perhaps be merged to ensure at least vispy 0.11 support. |
echo
and vispy
echo>=0.6
and vispy=0.11
Description
This adds fixes for some upstream API changes which should fix a large part of the currently failing tests:
list
has been removed fromecho
CatRom
filter withCatRom2D
, breaking most oftest_vispy_toolbar
and also reported in 3d scatter fails to plot with PyQt5 and GL errors glue#2311Making the latest
vispy
version required for the latter; forecho
there currently is no explicit dependency at all (probably pulled in from glue-core), but it's probably unlikely to run into a version < 0.2 now._
This leaves two points of test failure:
test_record
reporting errors on writing to a closed file, not sure yet what to make of this:VolumeVisual
and what is currently implemented inMultiIsoVisual
; putting this off to a separate PR.