Refactor how we handle aspect ratios to not depend on Matplotlib #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
refactor-aspect
branch
from
e9549b8
to
e8174f9
Compare
…thon to use the inline backend, but the inline backend overrode some rcParams and this caused issues with tests or when restoring sessions (the appearance of the plots changed). We now make sure the default backend is set to Agg.
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
+ Coverage 85.51% 85.56% +0.05%
==========================================
Files 235 235
Lines 20899 20962 +63
==========================================
+ Hits 17871 17937 +66
+ Misses 3028 3025 -3
Continue to review full report at Codecov.
|
…dependent (because of e.g. slightly different toolbar sizes)
astrofrog
added
Ready for final review
merge-when-ci-passes
and removed
work in progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Matplotlib deals with aspect ratio can be quite buggy and hard to control, so it would be easier to deal with it ourselves, with the bonus that if this is implemented in a generic way it could be used in glue-jupyter too.
This is currently a work in progress from a few months ago, so I need to remind myself of what worked/what didn't work, then make sure we add extensive tests!