feat: support for Voila v0.2 #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voila v0.2 has a dependency on jupyter-client>6. The current pinning of <6 is not necessary anymore (see glue-viz#2174). Closes glue-viz#2174.
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
- Coverage 88.04% 88.02% -0.03%
==========================================
Files 247 247
Lines 22956 22956
==========================================
- Hits 20211 20206 -5
- Misses 2745 2750 +5
Continue to review full report at Codecov.
|
|
@astrofrog do you have an idea why some test variants fail? |
|
Error related to jupyter/jupyter_client#523 |
mariobuikhuizen
force-pushed
the
feat_support_voila_0.2
branch
from
0fa7ae6
to
b22619f
Compare
mariobuikhuizen
force-pushed
the
feat_support_voila_0.2
branch
2 times, most recently
from
b670359
to
f928f31
Compare
astrofrog
added a commit
that referenced
this pull request
Nov 10, 2020
feat: support for Voila v0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voila v0.2 has a dependency on jupyter-client>6. The current pinning of <6 is not necessary any more (see #2174).
Closes #2174.